This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Migrate createPost to redux #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ jest.mock('actions/global_actions.jsx', () => ({ | |||
| })); | |||
|
|
|||
| jest.mock('actions/post_actions.jsx', () => ({ | |||
| createPost: jest.fn(), | |||
| createPost: jest.fn(() => ({type: 'MOCK_CREATE_POST'})), | |||
There was a problem hiding this comment.
Suggested change
| createPost: jest.fn(() => ({type: 'MOCK_CREATE_POST'})), | |
| createPost: jest.fn((...args) => ({type: 'MOCK_CREATE_POST', args})), |
I think it should have args so we can validate the params passed into it.
There was a problem hiding this comment.
the problem here is that the args are being generated in submitPost and is adding a pending_post_id and a timestamp that I don't really know who to mock
| for (const emoji of emojis) { | ||
| const trimmed = emoji.substring(1, emoji.length - 1); | ||
| emitEmojiPosted(trimmed); | ||
| export function createPost(post, files) { |
There was a problem hiding this comment.
Can we add test to createPost?
saturninoabril
approved these changes
Nov 6, 2018
jwilander
suggested changes
Nov 6, 2018
| if (emojis) { | ||
| for (const emoji of emojis) { | ||
| const trimmed = emoji.substring(1, emoji.length - 1); | ||
| dispatch(addRecentEmoji(trimmed)); |
There was a problem hiding this comment.
This should be doDispatch right?
There was a problem hiding this comment.
actually I'm going to get rid of the global dispatch in this file
|
@jwilander changes made |
jwilander
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Affected areas:
Ticket Link
https://mattermost.atlassian.net/browse/MM-12711
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed