This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[PLT-7773] Hide channel and team URLs from the sidebar in the desktop app #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asaadmahmood
approved these changes
Oct 26, 2017
|
Thanks @asaadmahmood! PR updated which adds track event when button is clicked. |
hmhealey
approved these changes
Oct 30, 2017
| element = ( | ||
| <button | ||
| className={'btn btn-link ' + rowClass} | ||
| onClick={() => this.handleClick(link)} |
There was a problem hiding this comment.
No change needed right now since this component isn't particularly efficient, but you'd usually want to avoid using an arrow function in component prop since that'll mean it's making a new function on every re-render. That's not that bad when it's a DOM element like button, but it'll cause PureComponents to re-render more often than necessary
ry-wang
pushed a commit
to ry-wang/mattermost-webapp
that referenced
this pull request
Nov 4, 2017
… app (mattermost#200) * hide channel and team URLs from the sidebar in the desktop app * add track event when button is clicked * Updating sidebar styles for desktop app
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hide channel and team URLs from the sidebar in the desktop app
@asaadmahmood Can I have a hand to fix CSS styling issues for desktop button? Thanks!
Ticket Link
Jira ticket: PLT-7773
Checklist