Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-12796 - Updating emoji reaction hover effect #1992

Merged
merged 1 commit into from
Nov 5, 2018
Merged

MM-12796 - Updating emoji reaction hover effect #1992

merged 1 commit into from
Nov 5, 2018

Conversation

asaadmahmood
Copy link
Contributor

Summary

MM-12796 - Updating emoji reaction hover effect

Ticket Link

https://mattermost.atlassian.net/browse/MM-12796

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Needs to be implemented in mobile (link to PR or User Story)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@asaadmahmood asaadmahmood added this to the v5.5.0 milestone Nov 1, 2018
@amyblais amyblais added the 2: Dev Review Requires review by a core commiter label Nov 1, 2018
@lieut-data lieut-data added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Nov 1, 2018
@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Nov 1, 2018
@amyblais
Copy link
Member

amyblais commented Nov 5, 2018

@cpanato Can you help merge + cherry-pick this PR?

@cpanato
Copy link
Contributor

cpanato commented Nov 5, 2018

@amyblais yes, doing that

@cpanato cpanato merged commit aee2b2f into mattermost:master Nov 5, 2018
@asaadmahmood asaadmahmood deleted the MM-12796 branch November 5, 2018 13:54
cpanato pushed a commit that referenced this pull request Nov 5, 2018
@asaadmahmood @cpanato
MM-12796 - Updating emoji reaction hover effect (#1992)
f09d02a
@cpanato cpanato added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Nov 5, 2018
@cpanato
Copy link
Contributor

cpanato commented Nov 5, 2018

cherry pick done @amyblais

@lindy65 lindy65 added Tests/Done Release tests have been written and removed 4: Reviews Complete All reviewers have approved the pull request labels Nov 5, 2018
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 5, 2018
@snyk-bot snyk-bot mentioned this pull request Apr 7, 2022
Open
@giuesposbit giuesposbit mentioned this pull request Jun 22, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lieut-data lieut-data lieut-data approved these changes

@sudheerDev sudheerDev sudheerDev approved these changes

Assignees
No one assigned
Labels
Changelog/Done Required changelog entry has been written CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.5.0
6 participants
@asaadmahmood @amyblais @cpanato @lieut-data @sudheerDev @lindy65