Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-12810 Webapp redirecting to select_team page when base url is hit #1945

Merged
merged 2 commits into from
Oct 26, 2018
Merged

MM-12810 Webapp redirecting to select_team page when base url is hit #1945

merged 2 commits into from
Oct 26, 2018

Conversation

sudheerDev
Copy link
Contributor

@sudheerDev sudheerDev commented Oct 26, 2018 •
edited
Loading

Summary

Props change is used for redirecting to default team which causes a race condition. User info is loaded into state triggering a props change so redirectUserToDefaultTeam take user to select_team page if there is a delay in state change for user teams.

Ticket Link

MM-12810

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • [] Added or updated unit tests (required for all new features)

@sudheerDev sudheerDev added the 2: Dev Review Requires review by a core commiter label Oct 26, 2018
enahum
enahum approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jwilander
jwilander approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice find 👍

@jwilander
Copy link
Member

Got a style error then ready to merge:

home/ubuntu/jenkins/workspace/w_mattermost-webapp_PR-1945-TC6BVEWLJ4JKMBQQ4HBH5OTT4AX7HOVF6A76HK2AE2DWGY4MSQGQ/components/root/root.jsx
  21:8  error  'UserStore' is defined but never used  no-unused-vars
✖ 1 problem (1 error, 0 warnings)

@sudheerDev
Copy link
Contributor Author

Done. Fixed lint. Waiting to hear about milestone on this ticket

@sudheerDev sudheerDev added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 26, 2018
@sudheerDev sudheerDev added this to the v5.5.0 milestone Oct 26, 2018
@sudheerDev sudheerDev merged commit 96752fe into mattermost:master Oct 26, 2018
@sudheerDev sudheerDev deleted the MM-12810 branch October 26, 2018 15:12
@sudheerDev sudheerDev mentioned this pull request Oct 26, 2018
Merged
2 tasks
lieut-data added a commit that referenced this pull request Oct 31, 2018
@lieut-data
Revert "MM-12810 Webapp redirecting to select_team page when base url…
c1af28a 
… is hit (#1945)"

This reverts commit 96752fe.
@amyblais amyblais modified the milestones: v5.5.0, v5.6.0 Nov 2, 2018
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 17, 2018
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 4: Reviews Complete All reviewers have approved the pull request labels Dec 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwilander jwilander jwilander approved these changes

@enahum enahum enahum approved these changes

Assignees

@sudheerDev sudheerDev

Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v5.6.0
5 participants
@sudheerDev @jwilander @enahum @lindy65 @amyblais