This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-12740 Move translations into redux store and remove LocalizationStore #1896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
approved these changes
Oct 15, 2018
components/root/root.jsx
Outdated
| $(window).unbind('storage'); | ||
| } | ||
|
|
||
| render() { | ||
| if (this.state.translations == null || this.state.configLoaded === false) { | ||
| if (this.state.configLoaded === false) { |
There was a problem hiding this comment.
nit: !this.state.configLoaded, or are we intentionally ignoring falsy but !== false values here?
There was a problem hiding this comment.
Good catch. Not intentional.
| @@ -1382,7 +1382,7 @@ | |||
| "analytics.team.totalUsers": "Total Active Users", | |||
| "announcement_bar.error.email_verification_required": "Check your email at {email} to verify the address. Cannot find the email?", | |||
| "announcement_bar.error.license_expired": "Enterprise license is expired and some features may be disabled. [Please renew](!{link}).", | |||
| "announcement_bar.error.license_expiring": "Enterprise license expires on {date}. [Prease renew](!{link}).", | |||
| return team && !team.delete_at > 0 && team.display_name != null; | ||
| }). | ||
| sort(sortTeamsByDisplayName); | ||
| return teams.filter((team) => { |
There was a problem hiding this comment.
nit: could just use a expressions here:
return teams.filter((team) => (
team && team.delete_at > 0 && team.display_name != null
)).sort((a, b) => (
compareTeamsByDisplayName(locale, a, b)
));There was a problem hiding this comment.
0/5 on how we do those. I'm just in the habit of always using a function body when it stretches over multiple lines
hmhealey
changed the title
hmhealey
added
Do Not Merge/Awaiting PR
hmhealey
added
4: Reviews Complete
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
…ore (mattermost#1896) * MM-12581 Move translations into redux store and remove LocalizationStore * Switch i18n file mocking to not use identity-obj-proxy * Address feedback
amyblais
added
Changelog/Done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saying things like "It's a fairly simple store anyway" seems to cause me a lot of problems.
This PR does a few major things:
Ticket Link
https://mattermost.atlassian.net/browse/MM-12740
Checklist