Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Update package-lock.json #1891

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Update package-lock.json #1891

merged 1 commit into from
Oct 16, 2018

Conversation

hmhealey
Copy link
Member

Just fixing a value that npm keeps changing

@hmhealey hmhealey added the 2: Dev Review Requires review by a core commiter label Oct 15, 2018
@crspeller
Copy link
Member

@hmhealey It's just going to change again. Can we just add it to the .gitignore? It's really annoying.

@enahum
Copy link
Contributor

enahum commented Oct 15, 2018

We should not add them to gitignore but we should do something like this mattermost/mattermost-mobile#2264

@crspeller
Copy link
Member

@hmhealey Let's try what Elias says.

Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we go with the ci option or not I'm 0/5 on changing this one

@hmhealey
Copy link
Member Author

@crspeller I'm pretty sure that it should only change when the package.json does, so I think someone may have forgotten to update it when they updated some other dependency. We've managed to go for at least a few months without this happening, so I don't think it's something that will happen frequently

@hmhealey
Copy link
Member Author

I'll look at npm ci though. That sounds like what I wanted npm install to do in the first place :p

@crspeller
Copy link
Member

Alright, we can merge this if it helps people in the meantime.

@crspeller crspeller merged commit 8a3992a into master Oct 16, 2018
@crspeller crspeller deleted the hh-package-lock branch October 16, 2018 19:27
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 16, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
5 participants