This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-11880 Have Team Settings modal use the patch endpoint instead of the update endpoint #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
suggested changes
Oct 10, 2018
saturninoabril
approved these changes
Oct 15, 2018
jwilander
added
4: Reviews Complete
lindy65
added
Tests/Not Needed
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
…he update endpoint (mattermost#1853) * Change team settings to use patch instead of update endpoint * Fix after rebase * Change team test to use patchTeam * Fix assertions
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switches the update team settings from using the /api/v4/teams endpoint to using the /api/v4/teams/patch endpoint.
Ticket Link
mattermost/mattermost#9358
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed