This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Message hook #1840
Merged
Message hook #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkraft
commented
Oct 5, 2018
|
|
||
| this.props.pluginHooks.forEach((o) => { | ||
| if (o && o.hook) { | ||
| message = o.hook(post, message); |
There was a problem hiding this comment.
I kept the message param in case hooks want to build upon changes made by other hooks. Of course any given hook could choose to totally ignore the changes made by other hooks and simply use the post.message field.
jwilander
reviewed
Oct 5, 2018
reducers/plugins/index.js
Outdated
| @@ -153,6 +153,28 @@ function components(state = {}, action) { | |||
| } | |||
| } | |||
|
|
|||
| function hooks(state = {}, action) { | |||
There was a problem hiding this comment.
We actually don't need a new reducer for this, we've been using the components reducer for practically everything. e.g. see the FilesWillUploadHook
jwilander
reviewed
Oct 5, 2018
components/post_markdown/index.js
Outdated
| export default PostMarkdown; | ||
| function mapStateToProps(state) { | ||
| return { | ||
| pluginHooks: state.plugins.hooks.MessageWillFormat, |
There was a problem hiding this comment.
You'll need to switch this to state.plugins.components.MessageWillFormat now as well
jwilander
added
4: Reviews Complete
lindy65
added
Tests/Not Needed
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
* Start implementing plugin hook for MessageWillFormat * Send entire post to webhook. (mattermost#1590) * Adds plugin-updated message to allow hooks to chain their message changes. * Updates snaps to reflect Redux connect use. * Reuses existing 'components' reducer. * Fix for wrong state key bug.
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds message hook.
Ticket Link
n/a
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed