Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-12499 - Updating badge icon #1838

Merged
merged 2 commits into from
Oct 5, 2018
Merged

MM-12499 - Updating badge icon #1838

merged 2 commits into from
Oct 5, 2018

Conversation

asaadmahmood
Copy link
Contributor

Please make sure you've read the pull request section of our code contribution guidelines.

When filling in a section please remove the help text and the above text.

Summary

MM-12499 - Updating badge icon

Ticket Link

https://mattermost.atlassian.net/browse/MM-12499

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Needs to be implemented in mobile (link to PR or User Story)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@asaadmahmood asaadmahmood added the 2: Dev Review Requires review by a core commiter label Oct 5, 2018
@asaadmahmood asaadmahmood requested review from hmhealey and enahum and removed request for hmhealey October 5, 2018 06:37
@asaadmahmood asaadmahmood added this to the v5.4.0 milestone Oct 5, 2018
@asaadmahmood asaadmahmood changed the base branch from release-5.4 to master October 5, 2018 13:12
@hmhealey hmhealey added CherryPick/Candidate A candidate for a quality or patch release, but not yet approved and removed 2: Dev Review Requires review by a core commiter labels Oct 5, 2018
@hmhealey hmhealey merged commit fdc4985 into mattermost:master Oct 5, 2018
hmhealey pushed a commit that referenced this pull request Oct 5, 2018
@asaadmahmood @hmhealey
MM-12499 - Updating badge icon (#1838)
84d982f 
* MM-12499 - Updating badge icon

* Updating badge file
@hmhealey hmhealey added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Candidate A candidate for a quality or patch release, but not yet approved labels Oct 5, 2018
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Oct 9, 2018
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Oct 12, 2018
fincha pushed a commit to fincha/mattermost-webapp that referenced this pull request Oct 21, 2018
@asaadmahmood
MM-12499 - Updating badge icon (mattermost#1838)
4b74cea 
* MM-12499 - Updating badge icon

* Updating badge file
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation Tests/Done Release tests have been written
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@asaadmahmood @hmhealey @enahum @amyblais @DHaussermann