This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-12082 Don't clear user's Teammate Name Display when it matches system default #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudheerDev
reviewed
Oct 3, 2018
| } else { | ||
| preferences.push(teammateNameDisplayPreference); | ||
| } | ||
| const preferences = [ |
There was a problem hiding this comment.
Is there a thumb rule about when we change from a single line to multiline assignments and destructuring?
There was a problem hiding this comment.
Not really. I usually do it when there's 3 or more items, but I don't think I'm consistent since I almost always break this.setState into multiple lines even when there's only one field being set.
There's an ESLint rule that we could use if we wanted to make it consistent though
sudheerDev
approved these changes
Oct 3, 2018
grundleborg
approved these changes
Oct 3, 2018
hmhealey
added a commit
that referenced
this pull request
Oct 3, 2018
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to maintain the user's setting as long as they've changed it at least once. The previous version cleared it if they set it to match the system-wide setting
Ticket Link
https://mattermost.atlassian.net/browse/MM-12082