This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-12227 Always provide defaults for Channel Notification Settings modal #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
approved these changes
Oct 1, 2018
lieut-data
approved these changes
Oct 1, 2018
hmhealey
added a commit
that referenced
this pull request
Oct 1, 2018
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix here is that the methods that open/close each section (eg.
handleUpdateDesktopSection) were resetting the state from the props, overriding the default that was set earlier in the modal's lifecycleTicket Link
https://mattermost.atlassian.net/browse/MM-12227
Checklist