This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-11954 Simplify "User's message" translation #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,10 +69,9 @@ export default class CommentedOn extends PureComponent { | |||
| <span> | |||
| <FormattedMessage | |||
| id='post_body.commentedOn' | |||
| defaultMessage='Commented on {name}{apostrophe} message: ' | |||
| defaultMessage='Commented on {name} message: ' | |||
There was a problem hiding this comment.
Does not match with the en.json.
There was a problem hiding this comment.
Ah right. I missed the {name}'s message the first time as well
saturninoabril
approved these changes
Sep 26, 2018
mkraft
approved these changes
Sep 27, 2018
esethna
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
lindy65
added
Tests/Not Needed
danmaas
added a commit
to coreplane/mattermost-webapp
that referenced
this pull request
Oct 1, 2018
…pdate-20180922 * commit 'cad0dc08c2b595c3668f829bd390aca5ddf690ff': (33 commits) comment typo (mattermost#1805) MM-12283 Add loader for more_channels modal (mattermost#1798) MM-12221: Pass channel and channel member to onClick handler for mobile channel header plugins. (mattermost#1728) Fixing scroll jumping for pinned and flagged posts. (mattermost#1795) MM-12257 preserve extra on logout (mattermost#1784) MM-12217 - Updating autocomplete css (mattermost#1790) Adding paging for elasticsearch results. (mattermost#1759) MM-12265 - Updating sidebar item css (mattermost#1792) MM-12351 - Updating default webhooks (mattermost#1791) remove one of two tooltips of unmute icon and replace with aria-label (mattermost#1779) Remove the reply bar in RHS (mattermost#1789) Accept direct values on isDissabled and isHidden (mattermost#1787) MM-12149 - Updating border for webhook images (mattermost#1786) Fix autocomplete staying open when deleting mention character at beginning of textbox (mattermost#1778) MM-12308 - Updating search popover styling (mattermost#1793) MM-11954 Simplify "User's message" translation (mattermost#1773) MM-12241 - Updating help text on DM Modal (mattermost#1788) MM-12130: Create a new page for displaying terms of service (mattermost#1735) [MM-4712] Add progress bar for uploads (mattermost#1713) MM-12205: notify on session expiration (mattermost#1751) ...
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
* MM-11954 Simplify "User's message" translation * Fix default message and update snapshots * Update snapshots
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
https://mattermost.atlassian.net/browse/MM-11954
Checklist