This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
PLT-7853 Added thumbnail for SVG attachments #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/file_attachment.jsx
Outdated
| @@ -49,6 +49,8 @@ export default class FileAttachment extends React.Component { | |||
| const thumbnailUrl = getFileThumbnailUrl(fileInfo.id); | |||
|
|
|||
| Utils.loadImage(thumbnailUrl, this.handleImageLoaded); | |||
| } else if (fileInfo.extesnion === 'svg') { | |||
There was a problem hiding this comment.
maybe a type on extesnion
There was a problem hiding this comment.
Good catch. That also meant the loading logic was broken since it should've been showing the loading indicator forever because of that typo
|
I swear I made a commit that did exactly this a while ago... Edit: I guess that was just for "previews" (mattermost/mattermost#7348). These should probably be made to share code. |
|
@ccbrown I've meant to combine the logic of those two since I wrote the current version of the file attachments. The |
cpanato
approved these changes
Oct 25, 2017
ccbrown
approved these changes
Oct 25, 2017
|
I'll merge this PR shortly, but I'm using it to test some changes to Mattermod quickly |
sudheerDev
pushed a commit
to sudheerDev/mattermost-webapp
that referenced
this pull request
Nov 3, 2017
* PLT-7853 Added thumbnail for SVG attachments * Fixed loading of SVG attachment thumbnail Moved create_post.jsx to folder and added redux-connect.
ry-wang
pushed a commit
to ry-wang/mattermost-webapp
that referenced
this pull request
Nov 4, 2017
* PLT-7853 Added thumbnail for SVG attachments * Fixed loading of SVG attachment thumbnail
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
…ors (#176) * Complete direct channels info in selectors * better error handling for joinChannel and createDirectChannel * error handling for deleteChannel * Fix unit tests
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
…ors (#176) * Complete direct channels info in selectors * better error handling for joinChannel and createDirectChannel * error handling for deleteChannel * Fix unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just uses the raw SVG file since that's probably smaller than loading a rasterized thumbnail image
Ticket Link
https://mattermost.atlassian.net/browse/PLT-7853
Checklist