This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-11647 - Updating sidebar item css #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saturninoabril
approved these changes
Sep 20, 2018
crspeller
approved these changes
Sep 20, 2018
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
lieut-data
added a commit
that referenced
this pull request
Nov 2, 2018
Commit 0d02b16 (#1738) changed `.sidebar-item` to have `display: flex`, resulting in a Desktop/Electron/Chromium-specific bug that would sometimes result in an unread channel name being rendered as both bolded and not bolded. An initial attempt at fixing this improved the behaviour some of the time, but didn't resolve the problem entirely. We've seen been able to reproduce the problem locally 100% of the time, and narrowed it down to what seems like a rendering "race" between in the CSS. It's likely this could be fixed with a larger refactor to avoid duplicate rules, but simply removing `position: relative` in this case appears to avoid the problem without any visual side effects.
9 tasks
lieut-data
added a commit
that referenced
this pull request
Nov 2, 2018
Commit 0d02b16 (#1738) changed `.sidebar-item` to have `display: flex`, resulting in a Desktop/Electron/Chromium-specific bug that would sometimes result in an unread channel name being rendered as both bolded and not bolded. An initial attempt at fixing this improved the behaviour some of the time, but didn't resolve the problem entirely. We've seen been able to reproduce the problem locally 100% of the time, and narrowed it down to what seems like a rendering "race" between in the CSS. It's likely this could be fixed with a larger refactor to avoid duplicate rules, but simply removing `position: relative` in this case appears to avoid the problem without any visual side effects.
lieut-data
added a commit
that referenced
this pull request
Nov 2, 2018
Commit 0d02b16 (#1738) changed `.sidebar-item` to have `display: flex`, resulting in a Desktop/Electron/Chromium-specific bug that would sometimes result in an unread channel name being rendered as both bolded and not bolded. An initial attempt at fixing this improved the behaviour some of the time, but didn't resolve the problem entirely. We've seen been able to reproduce the problem locally 100% of the time, and narrowed it down to what seems like a rendering "race" between in the CSS. It's likely this could be fixed with a larger refactor to avoid duplicate rules, but simply removing `position: relative` in this case appears to avoid the problem without any visual side effects.
JayaKrishnaNamburu
pushed a commit
to JayaKrishnaNamburu/mattermost-webapp
that referenced
this pull request
Dec 3, 2018
Commit 0d02b16 (mattermost#1738) changed `.sidebar-item` to have `display: flex`, resulting in a Desktop/Electron/Chromium-specific bug that would sometimes result in an unread channel name being rendered as both bolded and not bolded. An initial attempt at fixing this improved the behaviour some of the time, but didn't resolve the problem entirely. We've seen been able to reproduce the problem locally 100% of the time, and narrowed it down to what seems like a rendering "race" between in the CSS. It's likely this could be fixed with a larger refactor to avoid duplicate rules, but simply removing `position: relative` in this case appears to avoid the problem without any visual side effects.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MM-11647 - Updating sidebar item css
Ticket Link
https://mattermost.atlassian.net/browse/MM-11647
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed