Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-12153: Remove Default Server Language option from the config panel #1725

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

jespino
Copy link
Member

@jespino jespino commented Sep 19, 2018

Summary

Remove Default Server Language option from the config panel

Ticket Link

MM-12153

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed

@jespino jespino added the 2: Dev Review Requires review by a core commiter label Sep 19, 2018
Copy link
Contributor

@grundleborg grundleborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the ticket was to remove the setting altogether - just remove the mention of "log files" in the help text, as these aren't i18n'ed any more.

@saturninoabril
Copy link
Member

+1 on George. I missed that.

@jespino
Copy link
Member Author

jespino commented Sep 19, 2018

It wasn't clear for me from the conversation. But now is changed.

@amyblais amyblais added this to the v5.4.0 milestone Sep 20, 2018
@jespino
Copy link
Member Author

jespino commented Sep 21, 2018

@grundleborg PTAL

@grundleborg grundleborg merged commit ba8aab3 into mattermost:master Sep 21, 2018
@jespino jespino deleted the MM-12153 branch September 21, 2018 08:49
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Sep 21, 2018
@lindy65 lindy65 added Tests/Not Needed Does not require new release tests and removed 2: Dev Review Requires review by a core commiter labels Sep 23, 2018
fincha pushed a commit to fincha/mattermost-webapp that referenced this pull request Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants