This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-12056: Improve the state management for schema admin settings #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
commented
Sep 13, 2018
| @@ -666,13 +688,144 @@ export default class SchemaAdminSettings extends AdminSettings { | |||
| ); | |||
| } | |||
|
|
|||
| closeTooltip = () => { | |||
There was a problem hiding this comment.
All this is copied from AdminSettings class to remove the relationship (parent/child)
jespino
commented
Sep 13, 2018
| render = () => { | ||
| const schema = this.props.schema; | ||
|
|
||
| if (schema && schema.component) { | ||
| const CustomComponent = schema.component; | ||
| return (<CustomComponent {...this.props}/>); | ||
| } | ||
| return AdminSettings.prototype.render.call(this); | ||
| return ( |
There was a problem hiding this comment.
All this is copied from AdminSettings class to remove the relationship (parent/child)
grundleborg
approved these changes
Sep 14, 2018
|
@jespino I merged your SAML config changes so this now needs a rebase onto that. |
|
Rebased :) |
jespino
force-pushed
the
MM-12056
branch
2 times, most recently
from
211db18
to
e7e1e2b
Compare
jwilander
approved these changes
Sep 17, 2018
jwilander
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve the state management for schema admin settings.
Based on the fix of MM-12056, I decide to simplify how
schema_admin_settings work, removing inheritance, and removing the
UNSAFE_complenteWillUpdate method.
In the future the AdminSettings class will be removed, when every single admin panel is using the declarative interface. So the code duplication will be temporary only.
Ticket Link
MM-12056
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed