Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

PLT-7783 Update PAT help text #168

Merged
merged 4 commits into from
Oct 30, 2017
Merged

PLT-7783 Update PAT help text #168

merged 4 commits into from
Oct 30, 2017

Conversation

jwilander
Copy link
Member

Summary

Update PAT help text.

Ticket Link

https://mattermost.atlassian.net/browse/PLT-7783

@jwilander jwilander added the 1: PM Review Requires review by a product manager label Oct 18, 2017
@jwilander
Copy link
Member Author

jwilander commented Oct 18, 2017 •
edited
Loading

@jasonblais I made the text changes but looking at the modals after it might be worth making some minor improvements

screen shot 2017-10-18 at 11 31 07 am

That's getting a bit long for a checkbox IMO, maybe we make the second part help text with a grey color underneath?

screen shot 2017-10-18 at 11 30 56 am

To me this kind of looks weird with the rest of the modal, and might look better if grey colored like the other help text in the system console

I'm 1/5 on both of these

@jasonblais
Copy link
Contributor

@asaadmahmood Thoughts on the above two points?

I agree with the first point where we could have

  • Allow this account to generate personal access tokens. as the setting text with
  • Removing this permission doesn't delete existing tokens. To delete them, go to the user's Manage Tokens menu. below it as help text, in grey colour

We do this in the desktop app Settings page
image

For the second screenshot I'm 0/5

@asaadmahmood
Copy link
Contributor

asaadmahmood commented Oct 18, 2017 •
edited
Loading

First one sounds fine.
For the second one, if we want to have it at the top, I think it's fine, as being on the top it takes priority, so lowering it's opacity won't do a lot. Help text at the top is similar to how it is in our account settings modal.

Another thing we can do for the second one is that we can push the help text to the bottom, and reduce it's opacity. Screenshot attached.
screen shot 2017-10-18 at 10 57 08 pm

@jasonblais
Copy link
Contributor

@jwilander Would you need help with the UI changes for the "Manage Roles" screen?

For "Manage Tokens" screen: We'll want to keep the help text at the top. If the text is at the bottom and the user several tokens, the text may not be easily discoverable. So let's keep "Manage Tokens" screen as-is.

@jwilander
Copy link
Member Author

I can take care of it, thanks guys

@jwilander
Copy link
Member Author

Actually @asaadmahmood could I have your help with the help text coloring/indenting CSS? I feel like I'm just going to do it in a hacky way. I pushed a commit that separates the text out from the checkbox

@jasonblais
Copy link
Contributor

Created a ticket for Asaad to take a look at this and another PR for CSS changes: https://mattermost.atlassian.net/browse/PLT-7942

@asaadmahmood
Copy link
Contributor

Done @jasonblais @jwilander

@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 23, 2017
@mattermost mattermost deleted a comment from mattermod Oct 23, 2017
@mattermost mattermost deleted a comment from mattermod Oct 23, 2017
@jasonblais jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Oct 23, 2017
@mattermost mattermost deleted a comment from mattermod Oct 23, 2017
@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Oct 23, 2017
@mattermost mattermost deleted a comment from mattermod Oct 23, 2017
@jasonblais jasonblais closed this Oct 23, 2017
@jasonblais jasonblais reopened this Oct 23, 2017
@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Oct 23, 2017
@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Oct 24, 2017
@mattermost mattermost deleted a comment from mattermod Oct 24, 2017
@mattermost mattermost deleted a comment from mattermod Oct 24, 2017
@jasonblais jasonblais removed their assignment Oct 30, 2017
@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager Setup Old Test Server Triggers the creation of a test server labels Oct 30, 2017
@mattermost mattermost deleted a comment from mattermod Oct 30, 2017
@mattermost mattermost deleted a comment from mattermod Oct 30, 2017
@jasonblais
Copy link
Contributor

@jwilander Before this can be merged, it'll also need a rebase,

@jwilander
Copy link
Member Author

Already done :P

@jwilander jwilander requested review from MusikPolice and enahum and removed request for jasonblais October 30, 2017 16:54
@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 30, 2017
@jwilander jwilander merged commit 01653df into master Oct 30, 2017
@jwilander jwilander deleted the plt-7783 branch October 30, 2017 18:09
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Needed Requires documentation Docs/Done Required documentation has been written and removed Docs/Needed Requires documentation labels Nov 2, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Nov 4, 2017
ry-wang pushed a commit to ry-wang/mattermost-webapp that referenced this pull request Nov 4, 2017
@jwilander @ry-wang
PLT-7783 Update PAT help text (mattermost#168)
87738a0 
* Update PAT help text

* Separate help text from checkbox

* Updating UI for access tokens

* Removing div, and adding span for help text
hmhealey added a commit that referenced this pull request Aug 28, 2020
@hmhealey
RN-219 Reverted lastFetchTime for posts and switched it to be based o…
a322232 
…n the last Post.CreateAt (#168)

* Revert "Add an internal reducer to store the last time a channel fetched posts (#142)"

This reverts commit 5d9ed45.

* RN-219 Changed post load on reconnect to be based on post update at time
hmhealey added a commit that referenced this pull request Mar 17, 2021
@hmhealey @enahum
RN-219 Reverted lastFetchTime for posts and switched it to be based o…
723745e 
…n the last Post.CreateAt (#168)

* Revert "Add an internal reducer to store the last time a channel fetched posts (#142)"

This reverts commit 5d9ed45.

* RN-219 Changed post load on reconnect to be based on post update at time
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MusikPolice MusikPolice MusikPolice approved these changes

@enahum enahum enahum approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Done Required documentation has been written Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jwilander @jasonblais @asaadmahmood @MusikPolice @enahum @hmhealey @esethna @lindalumitchell