This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Swap order between Romanian and Turkish #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Romanian should be below Portuguese, above Turkish
enahum
approved these changes
Aug 13, 2018
|
@jasonblais need to update the tests |
|
If I just swap the order value and revert the other changes, do I need to update the tests? |
|
@jasonblais no, but I can fix that if you want |
|
That would be helpful @cpanato :) |
|
@enahum PTAL |
cpanato
approved these changes
Aug 14, 2018
jasonblais
added
4: Reviews Complete
|
Thanks Carlos! Ready to merge (don't have permissions to merge) |
amyblais
added
Changelog/Not Needed
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
* Swap order between Romanian and Turkish Romanian should be below Portuguese, above Turkish * Update i18n.jsx * reorder and fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Romanian should be below Portuguese, above Turkish