Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Gh 8347 Add group channels as part of the "more direct messages" suggestions #1556

Merged
merged 10 commits into from
Nov 8, 2018

Conversation

pradeepmurugesan
Copy link
Contributor

Summary

Add group channels as part of the "more direct messages" suggestions

Ticket Link

mattermost/mattermost#8347

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

@pradeepmurugesan
Copy link
Contributor Author

I have ignore the following, thinking it can be done in the next iteration.

Steps:

  1. I open the more direct messages dialog
  2. filter and click on a group message option
  3. the users in that group gets added
  4. the same group message option still comes in the suggestion list.

though, clicking on the same has no effect. i.e won't add the users again.

@mattermost mattermost deleted a comment from mattermod Aug 21, 2018
@mattermost mattermost deleted a comment from mattermod Aug 21, 2018
@mattermost mattermost deleted a comment from mattermod Aug 21, 2018
@esethna esethna added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Aug 21, 2018
@mattermost mattermost deleted a comment from mattermod Aug 21, 2018
@mattermost mattermost deleted a comment from mattermod Aug 21, 2018
@mattermost mattermost deleted a comment from mattermod Aug 21, 2018
@esethna esethna added the Setup Old Test Server Triggers the creation of a test server label Aug 21, 2018
@esethna
Copy link
Contributor

esethna commented Aug 21, 2018

@cpanato can you help look into this spinmint? Having trouble getting it up

@cpanato
Copy link
Contributor

cpanato commented Aug 22, 2018

@esethna fixed

Copy link
Contributor

@esethna esethna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sweet @pradeepmurugesan! Such a nice feature, awesome work. A few comments we should address:

  1. Theming and other CSS. Adding @asaadmahmood to help with some alignment and theming:
    image

image

  1. I think we need to address how this feature works with different "Teammate Name Display" Account Settings. It seems that it matches differently when "First and Last Name" or "Nickname" is selected than if "username" is selected. I would expect that it searches all name types (first, last, nickname, username) and displays the same results regardless of which setting is selected.

@esethna esethna added the Awaiting Submitter Action Blocked on the author label Aug 27, 2018
@pradeepmurugesan
Copy link
Contributor Author

@esethna thanks for the feedback. Will work on the same and let you know.

@mattermod
Copy link
Contributor

Spinmint test running for more than 7 days. This test server was terminated.

@esethna
Copy link
Contributor

esethna commented Sep 11, 2018

Hey @pradeepmurugesan, just checking in, let us know if you have any questions

@pradeepmurugesan
Copy link
Contributor Author

Hi @esethna .. I have the fix ready for searching all the fields.. Quite busy with travel and office stuff. Will try to push it this weekend..

Sorry for the delay

@esethna
Copy link
Contributor

esethna commented Sep 12, 2018

Awesome, thanks @pradeepmurugesan! Appreciate your help here, excited about the feature!

@esethna esethna removed the Setup Old Test Server Triggers the creation of a test server label Sep 13, 2018
@mattermost mattermost deleted a comment from mattermod Sep 13, 2018
@mattermost mattermost deleted a comment from mattermod Sep 13, 2018
@esethna esethna self-assigned this Nov 1, 2018
@hmhealey hmhealey added Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed 2: Dev Review Requires review by a core commiter labels Nov 5, 2018
@hmhealey
Copy link
Member

hmhealey commented Nov 5, 2018

New changes look good. We're just waiting on the redux PR then

Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just need the redux PR

@hmhealey
Copy link
Member

hmhealey commented Nov 8, 2018

@pradeepmurugesan Redux PR is merged. Once that's used here, we'll be good to merge this!

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request Awaiting Submitter Action Blocked on the author and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Nov 8, 2018
@hmhealey hmhealey removed the Awaiting Submitter Action Blocked on the author label Nov 8, 2018
@hmhealey hmhealey merged commit 03c0912 into mattermost:master Nov 8, 2018
@jwilander
Copy link
Member

Great work @pradeepmurugesan 😃

@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels Nov 17, 2018
@lindy65 lindy65 removed the 4: Reviews Complete All reviewers have approved the pull request label Dec 4, 2018
@DHaussermann DHaussermann added the Tests/Done Release tests have been written label Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Hacktoberfest Tests/Done Release tests have been written
Projects
None yet