-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Gh 8347 Add group channels as part of the "more direct messages" suggestions #1556
Conversation
dfdd294
to
65f8c82
Compare
65f8c82
to
05fba83
Compare
I have ignore the following, thinking it can be done in the next iteration. Steps:
though, clicking on the same has no effect. i.e won't add the users again. |
05fba83
to
e494226
Compare
@cpanato can you help look into this spinmint? Having trouble getting it up |
@esethna fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sweet @pradeepmurugesan! Such a nice feature, awesome work. A few comments we should address:
- Theming and other CSS. Adding @asaadmahmood to help with some alignment and theming:
- I think we need to address how this feature works with different "Teammate Name Display" Account Settings. It seems that it matches differently when "First and Last Name" or "Nickname" is selected than if "username" is selected. I would expect that it searches all name types (first, last, nickname, username) and displays the same results regardless of which setting is selected.
@esethna thanks for the feedback. Will work on the same and let you know. |
Spinmint test running for more than 7 days. This test server was terminated. |
Hey @pradeepmurugesan, just checking in, let us know if you have any questions |
Hi @esethna .. I have the fix ready for searching all the fields.. Quite busy with travel and office stuff. Will try to push it this weekend.. Sorry for the delay |
Awesome, thanks @pradeepmurugesan! Appreciate your help here, excited about the feature! |
New changes look good. We're just waiting on the redux PR then |
9a8e21f
to
26bc7bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just need the redux PR
@pradeepmurugesan Redux PR is merged. Once that's used here, we'll be good to merge this! |
…and last names of profile
26bc7bf
to
e108cc8
Compare
Great work @pradeepmurugesan 😃 |
Summary
Add group channels as part of the "more direct messages" suggestions
Ticket Link
mattermost/mattermost#8347
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-style
to check for style errors (required for all pull requests)make test
to ensure unit and component tests passed