This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-11556: leverage getDirectAndGroupChannels #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new selector returns all group messages instead of suppressing ones that were manually or automatically closed. This also means archived direct and group channels are returned.
|
Needs to be updated to point at the relevant redux commit. |
enahum
approved these changes
Aug 3, 2018
sudheerDev
added
the
Do Not Merge/Awaiting PR
sudheerDev
approved these changes
Aug 7, 2018
lieut-data
force-pushed
the
mm-11556-quick-switch-closed-group-messages
branch
from
1415f3d
to
ca8aa7d
Compare
lieut-data
added
4: Reviews Complete
…-switch-closed-group-messages
lieut-data
force-pushed
the
mm-11556-quick-switch-closed-group-messages
branch
from
ca8aa7d
to
043b571
Compare
amyblais
added
Changelog/Not Needed
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
* MM-11556: leverage getDirectAndGroupChannels This new selector returns all group messages instead of suppressing ones that were manually or automatically closed. This also means archived direct and group channels are returned. * npm add mattermost/mattermost-redux#eb191aec1e274266414466bf5c222c9cff39881d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This new selector returns all group messages instead of suppressing ones that were manually or automatically closed.
This also means archived direct and group channels are returned. Direct and group channels aren't archived in quite the same way -- the users in question must be deleted. The behaviour observed with this PR seems reasonable (they show up in the quick switcher), but feedback welcome.
Ticket Link
https://mattermost.atlassian.net/browse/MM-11556
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed