Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Don't repeat yourself: Cleaning up executeCommand #143

Merged
merged 1 commit into from
Oct 11, 2017
Merged

Don't repeat yourself: Cleaning up executeCommand #143

merged 1 commit into from
Oct 11, 2017

Conversation

ccbrown
Copy link
Contributor

@ccbrown ccbrown commented Oct 10, 2017 •
edited
Loading

Summary

I prototyped out this suggestion and consolidated this to do so. I'm not gonna put in a PR for the suggestion because it introduces security concerns, but I can at least put in this.

Ticket Link

N/A

Checklist

N/A

@ccbrown ccbrown added the 2: Dev Review Requires review by a core commiter label Oct 10, 2017
hmhealey
hmhealey approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@hmhealey hmhealey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should really look at consolidating more of the CreateComment and CreatePost components in the future since they really do have mostly duplicated code

@hmhealey hmhealey added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Oct 11, 2017
@ccbrown ccbrown merged commit eea995d into mattermost:master Oct 11, 2017
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Oct 16, 2017
@jasonblais jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Nov 1, 2017
lieut-data pushed a commit that referenced this pull request Oct 10, 2018
@lieut-data
Refactored to rename "service terms" to "terms of service" (#1846)
ceb6ad5 
* #143 refactored 'service terms' to 'terms of service'

* 124 Renamed EnableCustomServiceTerms feature flag to EnableCustomTermsOfService

* merged master

* #124 renamed selectot from 'service terms' to 'terms of service'

* update mattermost-redux commit
lieut-data added a commit that referenced this pull request Oct 10, 2018
@lieut-data
Refactored to rename "service terms" to "terms of service" (#1846)
a10dcfc 
* #143 refactored 'service terms' to 'terms of service'

* 124 Renamed EnableCustomServiceTerms feature flag to EnableCustomTermsOfService

* merged master

* #124 renamed selectot from 'service terms' to 'terms of service'

* update mattermost-redux commit
fincha pushed a commit to fincha/mattermost-webapp that referenced this pull request Oct 21, 2018
Refactored to rename "service terms" to "terms of service" (mattermos…
a419e3f 
…t#1846)

* mattermost#143 refactored 'service terms' to 'terms of service'

* 124 Renamed EnableCustomServiceTerms feature flag to EnableCustomTermsOfService

* merged master

* mattermost#124 renamed selectot from 'service terms' to 'terms of service'

* update mattermost-redux commit
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@jwilander @hmhealey
Merge pull request #143 from 94117nl/master
1f97e24 
Add redux stuff for fetching, editing commands
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
@hmhealey
Refactored to rename "service terms" to "terms of service" (#671)
24fb6fd 
* #143 refactored 'service terms' to 'terms of service'

* 124 Renamed EnableCustomServiceTerms feature flag to EnableCustomTermsOfService

* 124 reverted version

* reverted package lock

* #124 renamed selectot from 'service terms' to 'terms of service'
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@jwilander
Merge pull request #143 from 94117nl/master
8028bd2 
Add redux stuff for fetching, editing commands
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
@lieut-data
Refactored to rename "service terms" to "terms of service" (#671)
f1453e5 
* #143 refactored 'service terms' to 'terms of service'

* 124 Renamed EnableCustomServiceTerms feature flag to EnableCustomTermsOfService

* 124 reverted version

* reverted package lock

* #124 renamed selectot from 'service terms' to 'terms of service'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hmhealey hmhealey hmhealey approved these changes

@saturninoabril saturninoabril saturninoabril approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccbrown @hmhealey @saturninoabril @jasonblais @lindalumitchell