This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-11158: fix subpath logout #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fall back to window.basename instead of window.location.origin, to ensure the subpath is reflected on logout.
lieut-data
force-pushed
the
mm-11158-fix-subpath-logout
branch
from
7f3f9a7
to
a9965f7
Compare
saturninoabril
approved these changes
Jul 5, 2018
|
Yeah, I see what you mean: the input to the selector is not only the store, so it's not really a true selector. I'll leave it as-is for now to reduce churn, but keep this in mind going forward -- thanks! |
sudheerDev
approved these changes
Jul 6, 2018
sudheerDev
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
fincha
pushed a commit
to fincha/mattermost-webapp
that referenced
this pull request
Oct 21, 2018
Fall back to window.basename instead of window.location.origin, to ensure the subpath is reflected on logout.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fall back to
window.basenameinstead ofwindow.location.origin, to ensure the subpath is reflected on logout. This ended up being a last minute regression in the PR phase :/Ticket Link
https://mattermost.atlassian.net/browse/MM-11158
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed