This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[PLT-7778] Pre-populate token/API endpoints for GitLab #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddf69dc
to
edfab41
Compare
jasonblais
suggested changes
Oct 10, 2017
There was a problem hiding this comment.
Great work!
Just two minor notes/comments:
1 - On a server with Enterprise license installed, the GitLab Site URL is non-editable. Repro steps:
- upload an E20 Enterprise license on a Mattermost install
- Go to System Console > OAuth 2.0
- Select GitLab from the dropdown
- Try to edit GitLab site URL field
- Observed: Field not editable
PS: Given this is only on an Enterprise-licensed server, let me know if you have any trouble reproducing it.
2 - When populating the token/API endpoints, would it be possible to remove a trailing slash from the GitLab Site URL if one is present? I can see admins doing that by accident, resulting in a double slash for the token/API endpoints
PS: We automatically trim trailing slash from the System Console > Configuration > SiteURL setting. So that might be a good comparison.
|
@jasonblais Will look into it! |
jasonblais
approved these changes
Oct 18, 2017
hmhealey
approved these changes
Oct 19, 2017
jwilander
approved these changes
Oct 19, 2017
|
Nice work @R-Wang97 ! There's an issue with our build system but as soon as that's resolved we'll merge this in |
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 31, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Oct 31, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 1, 2017
ry-wang
pushed a commit
to ry-wang/mattermost-webapp
that referenced
this pull request
Nov 4, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 10, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 11, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 13, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 13, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 13, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 14, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 15, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 21, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Nov 23, 2017
dmeza
pushed a commit
to uber-archive/mattermost-webapp
that referenced
this pull request
Dec 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rather than having a user manually enter the
TokenandAPIendpoints for GitLab, they now just need to enter the site URL, and theToken,API, andAuthendpoints will be automatically generated.Change has been made for both regular and enterprise versions.
Ticket Link
mattermost/mattermost#7558
https://mattermost.atlassian.net/browse/PLT-7778
Checklist