Added additional unit tests

components/admin_console/custom_url_schemes_setting.jsx

@@ -8,12 +8,12 @@ import * as Utils from 'utils/utils';
 
 import Setting from './setting';
 
-export default class TextSetting extends React.Component {
+export default class CustomUrlSchemesSetting extends React.Component {
  static get propTypes() {
  return {
  id: PropTypes.string.isRequired,
  value: PropTypes.array.isRequired,
- onChange: PropTypes.func,
+ onChange: PropTypes.func.isRequired,
  disabled: PropTypes.bool,
  setByEnv: PropTypes.bool.isRequired,
  };

tests/components/__snapshots__/markdown.test.jsx.snap

@@ -0,0 +1,17 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`components/Markdown should not render markdown when formatting is disabled 1`] = `
+<span>
+ This _is_ some **Markdown**
+</span>
+`;
+
+exports[`components/Markdown should render properly 1`] = `
+Array [
+ <p
+ key="0"
+ />,
+ "
+",
+]
+`;

tests/components/admin_console/__snapshots__/custom_url_scheme_setting.test.jsx.snap

@@ -0,0 +1,96 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`components/AdminConsole/CustomUrlSchemeSetting initial state with multiple items 1`] = `
+<Settings
+ helpText="Allow message text to link if it begins with any of the URL schemes listed here. By default, the following schemes will create links: \\"http\\", \\"https\\", \\"ftp\\", \\"tel\\", and \\"mailto\\"."
+ inputId="MySetting"
+ label="Custom URL Schemes:"
+ setByEnv={false}
+>
+ <input
+ className="form-control"
+ disabled={false}
+ id="MySetting"
+ onChange={[Function]}
+ placeholder="E.g.: \\"git,smtp\\""
+ type="text"
+ value="git,smtp,steam"
+ />
+</Settings>
+`;
+
+exports[`components/AdminConsole/CustomUrlSchemeSetting initial state with no items 1`] = `
+<Settings
+ helpText="Allow message text to link if it begins with any of the URL schemes listed here. By default, the following schemes will create links: \\"http\\", \\"https\\", \\"ftp\\", \\"tel\\", and \\"mailto\\"."
+ inputId="MySetting"
+ label="Custom URL Schemes:"
+ setByEnv={false}
+>
+ <input
+ className="form-control"
+ disabled={false}
+ id="MySetting"
+ onChange={[Function]}
+ placeholder="E.g.: \\"git,smtp\\""
+ type="text"
+ value=""
+ />
+</Settings>
+`;
+
+exports[`components/AdminConsole/CustomUrlSchemeSetting initial state with one item 1`] = `
+<Settings
+ helpText="Allow message text to link if it begins with any of the URL schemes listed here. By default, the following schemes will create links: \\"http\\", \\"https\\", \\"ftp\\", \\"tel\\", and \\"mailto\\"."
+ inputId="MySetting"
+ label="Custom URL Schemes:"
+ setByEnv={false}
+>
+ <input
+ className="form-control"
+ disabled={false}
+ id="MySetting"
+ onChange={[Function]}
+ placeholder="E.g.: \\"git,smtp\\""
+ type="text"
+ value="git"
+ />
+</Settings>
+`;
+
+exports[`components/AdminConsole/CustomUrlSchemeSetting renders properly when disabled 1`] = `
+<Settings
+ helpText="Allow message text to link if it begins with any of the URL schemes listed here. By default, the following schemes will create links: \\"http\\", \\"https\\", \\"ftp\\", \\"tel\\", and \\"mailto\\"."
+ inputId="MySetting"
+ label="Custom URL Schemes:"
+ setByEnv={false}
+>
+ <input
+ className="form-control"
+ disabled={true}
+ id="MySetting"
+ onChange={[Function]}
+ placeholder="E.g.: \\"git,smtp\\""
+ type="text"
+ value="git,smtp"
+ />
+</Settings>
+`;
+
+exports[`components/AdminConsole/CustomUrlSchemeSetting renders properly when set by environment variable 1`] = `
+<Settings
+ helpText="Allow message text to link if it begins with any of the URL schemes listed here. By default, the following schemes will create links: \\"http\\", \\"https\\", \\"ftp\\", \\"tel\\", and \\"mailto\\"."
+ inputId="MySetting"
+ label="Custom URL Schemes:"
+ setByEnv={true}
+>
+ <input
+ className="form-control"
+ disabled={true}
+ id="MySetting"
+ onChange={[Function]}
+ placeholder="E.g.: \\"git,smtp\\""
+ type="text"
+ value="git,smtp"
+ />
+</Settings>
+`;

tests/components/admin_console/custom_url_scheme_setting.test.jsx

@@ -0,0 +1,162 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+import React from 'react';
+import {shallow} from 'enzyme';
+
+import CustomUrlSchemesSetting from 'components/admin_console/custom_url_schemes_setting';
+
+describe('components/AdminConsole/CustomUrlSchemeSetting', () => {
+ const baseProps = {
+ id: 'MySetting',
+ value: ['git', 'smtp'],
+ onChange: jest.fn(),
+ disabled: false,
+ setByEnv: false,
+ };
+
+ describe('initial state', () => {
+ test('with no items', () => {
+ const props = {
+ ...baseProps,
+ value: [],
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+
+ expect(wrapper.state('value')).toEqual('');
+ });
+
+ test('with one item', () => {
+ const props = {
+ ...baseProps,
+ value: ['git'],
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+
+ expect(wrapper.state('value')).toEqual('git');
+ });
+
+ test('with multiple items', () => {
+ const props = {
+ ...baseProps,
+ value: ['git', 'smtp', 'steam'],
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+
+ expect(wrapper.state('value')).toEqual('git,smtp,steam');
+ });
+ });
+
+ describe('onChange', () => {
+ test('called on change to empty', () => {
+ const props = {
+ ...baseProps,
+ onChange: jest.fn(),
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+
+ wrapper.find('input').simulate('change', {target: {value: ''}});
+
+ expect(props.onChange).toBeCalledWith(baseProps.id, []);
+ });
+
+ test('called on change to one item', () => {
+ const props = {
+ ...baseProps,
+ onChange: jest.fn(),
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+
+ wrapper.find('input').simulate('change', {target: {value: ' steam '}});
+
+ expect(props.onChange).toBeCalledWith(baseProps.id, ['steam']);
+ });
+
+ test('called on change to two items', () => {
+ const props = {
+ ...baseProps,
+ onChange: jest.fn(),
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+
+ wrapper.find('input').simulate('change', {target: {value: 'steam, git'}});
+
+ expect(props.onChange).toBeCalledWith(baseProps.id, ['steam', 'git']);
+ });
+
+ test('called on change to more items', () => {
+ const props = {
+ ...baseProps,
+ onChange: jest.fn(),
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+
+ wrapper.find('input').simulate('change', {target: {value: 'ts3server, smtp, ms-excel'}});
+
+ expect(props.onChange).toBeCalledWith(baseProps.id, ['ts3server', 'smtp', 'ms-excel']);
+ });
+
+ test('called on change with extra commas', () => {
+ const props = {
+ ...baseProps,
+ onChange: jest.fn(),
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+
+ wrapper.find('input').simulate('change', {target: {value: ',,,,,chrome,,,,ms-excel,,'}});
+
+ expect(props.onChange).toBeCalledWith(baseProps.id, ['chrome', 'ms-excel']);
+ });
+ });
+
+ test('renders properly when disabled', () => {
+ const props = {
+ ...baseProps,
+ disabled: true,
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+ });
+
+ test('renders properly when set by environment variable', () => {
+ const props = {
+ ...baseProps,
+ setByEnv: true,
+ };
+
+ const wrapper = shallow(
+ <CustomUrlSchemesSetting {...props}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+ });
+});

tests/components/markdown.test.jsx

@@ -0,0 +1,38 @@
+// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
+// See LICENSE.txt for license information.
+
+import React from 'react';
+import {shallow} from 'enzyme';
+
+import Markdown from 'components/markdown/markdown';
+
+describe('components/Markdown', () => {
+ const baseProps = {
+ channelNamesMap: {},
+ enableFormatting: true,
+ mentionKeys: [],
+ message: 'This _is_ some **Markdown**',
+ siteURL: 'https://markdown.example.com',
+ team: {name: 'yourteamhere'},
+ hasImageProxy: false,
+ };
+
+ test('should render properly', () => {
+ const wrapper = shallow(
+ <Markdown {...baseProps}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+ });
+
+ test('should not render markdown when formatting is disabled', () => {
+ const props = {
+ ...baseProps,
+ enableFormatting: false,
+ };
+
+ const wrapper = shallow(
+ <Markdown {...props}/>
+ );
+ expect(wrapper).toMatchSnapshot();
+ });
+});