Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

[MM-51009] - Remove redundant CSS rule for timestamps in compact mode #12331

Merged
merged 1 commit into from
Mar 8, 2023
Merged

[MM-51009] - Remove redundant CSS rule for timestamps in compact mode #12331

merged 1 commit into from
Mar 8, 2023

Conversation

nevyangelova
Copy link
Contributor

Summary

Fix missing timestamp caused by redundant css rule in compact mode

Ticket Link

https://mattermost.atlassian.net/browse/MM-51009

Release Note

NONE

@nevyangelova nevyangelova added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Mar 7, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@nevyangelova nevyangelova added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Test Results

       1 files     815 suites   19m 59s ⏱️
6 933 tests 6 932 ✔️ 1 💤 0 ❌
7 109 runs  7 108 ✔️ 1 💤 0 ❌

Results for commit 5e3b4c1.

@nevyangelova
Copy link
Contributor Author

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@amyblais amyblais added this to the v7.9.0 milestone Mar 7, 2023
@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Mar 7, 2023
@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 7, 2023
@mm-cloud-bot
Copy link

Creating a new SpinWick test server using Mattermost Cloud.

@mm-cloud-bot
Copy link

Mattermost test server created! 🎉

Access here: https://mattermost-webapp-pr-12331.test.mattermost.cloud

Account Type Username Password
Admin sysadmin Sys@dmin123
User user-1 User-1@123

furqanmlk
furqanmlk approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected.

Before
image

After
image

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 7, 2023
@amyblais amyblais added the AutoMerge used by Mattermod to merge PR automatically label Mar 8, 2023
@mattermost-build
Copy link
Contributor

Will try to auto merge this PR once all tests and checks are passing. This might take up to an hour.

@mattermost-build
Copy link
Contributor

Trying to auto merge this PR.

@mattermost-build mattermost-build merged commit 0c6d525 into master Mar 8, 2023
@mattermost-build
Copy link
Contributor

Pull Request successfully merged
SHA: 0c6d525

@mattermost-build mattermost-build deleted the MM-51009 branch March 8, 2023 13:59
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the master branch and cleaning up.

@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 8, 2023
@mattermost-build mattermost-build removed the AutoMerge used by Mattermod to merge PR automatically label Mar 8, 2023
@amyblais
Copy link
Member

amyblais commented Mar 8, 2023

@AshishDhama Are you open to help open manual cherry-pick PRs for release-7.9 and cloud branches?

AshishDhama pushed a commit that referenced this pull request Mar 8, 2023
@AshishDhama
[MM-51009] - Remove redundant CSS rule for timestamps in compact mode (…
84b1380 
…#12331)

Automatic Merge
mattermost-build pushed a commit that referenced this pull request Mar 8, 2023
@AshishDhama
[MM-51009] - Remove redundant CSS rule for timestamps in compact mode (…
12e0a96 
…#12331) (#12334)

Automatic Merge
@amyblais
Copy link
Member

amyblais commented Mar 8, 2023

@AshishDhama Are you open to help open manual cherry-pick PRs for release-7.9 and cloud branches?

@AshishDhama Thank you for submitting a PR for v7.9, also a PR for the cloud branch is appreciated 🙏

AshishDhama pushed a commit that referenced this pull request Mar 8, 2023
@AshishDhama
[MM-51009] - Remove redundant CSS rule for timestamps in compact mode (…
ccae1cf 
…#12331)

Automatic Merge
@AshishDhama AshishDhama mentioned this pull request Mar 8, 2023
Merged
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 8, 2023
amyblais pushed a commit that referenced this pull request Mar 8, 2023
@AshishDhama
[MM-51009] - Remove redundant CSS rule for timestamps in compact mode (…
c46f4f1 
…#12331) (#12337)

Automatic Merge

Co-authored-by: na <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AshishDhama AshishDhama AshishDhama approved these changes

@furqanmlk furqanmlk furqanmlk approved these changes

Assignees

@AshishDhama AshishDhama

@nevyangelova nevyangelova

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nevyangelova @mattermost-build @mm-cloud-bot @amyblais @furqanmlk @AshishDhama