Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Create CONTRIBUTING.md #1231

Merged
merged 1 commit into from
Jun 8, 2018
Merged

Create CONTRIBUTING.md #1231

merged 1 commit into from
Jun 8, 2018

Conversation

jasonblais
Copy link
Contributor

No description provided.

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label May 19, 2018
@jasonblais jasonblais requested a review from mkraft May 25, 2018 20:47
After a PR is merged:
- External Contributions: PM closes the [Help Wanted] issue and related JIRA ticket.
- Internal Contributions: Core committer resolves the JIRA ticket.
- PM follows up for docs and changelog, and QA for release tests.
Copy link
Contributor

@mkraft mkraft May 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonblais What are the absolute minimum things a contributor would need to know before submitting a pull request?

Does specific knowledge of the labels system and how they're used by the PMs qualify as required knowledge that would preclude a contributor from submitting a PR?

What about other steps of the review process? Do they need to know all steps? Some steps? Any steps at all?

Once the minimum required knowledge is determined then I would have two subsequent questions:

  1. Which required knowledge can we then make obsolete?
  2. Finally, what are the minimum number of words we can use to describe our paired-down list of required knowledge?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process could be separated into its own page and linked from CONTRIBUTING.md if a contributor is interested to learn more about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah so this is just a copy/paste of the existing docs with a new process in the works: sounds like some good improvements are in the works and that's great! 👍

@jasonblais jasonblais added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels May 28, 2018
@cpanato
Copy link
Contributor

cpanato commented Jun 8, 2018

need rebase

@jasonblais
Copy link
Contributor Author

@cpanato I don't know how to rebase :/

@cpanato
Copy link
Contributor

cpanato commented Jun 8, 2018

@jasonblais

$ git fetch -p
$ git checkout jasonblais-patch-2
$git rebase -i origin/master
$git push -f origin jasonblais-patch-2

@cpanato
Copy link
Contributor

cpanato commented Jun 8, 2018

i can do that as well :)

@cpanato
Copy link
Contributor

cpanato commented Jun 8, 2018

done

@jasonblais
Copy link
Contributor Author

Thank you :)

@cpanato cpanato merged commit bfeff6d into master Jun 8, 2018
@cpanato cpanato deleted the jasonblais-patch-2 branch June 8, 2018 16:13
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Jun 8, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Jun 13, 2018
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
* actions/users: add options to get profiles in channel

* add types
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants