Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-50803 Fix restore post modal styles applying to other modals #12286

Merged
merged 1 commit into from
Mar 3, 2023
Merged

MM-50803 Fix restore post modal styles applying to other modals #12286

merged 1 commit into from
Mar 3, 2023

Conversation

hmhealey
Copy link
Member

The styling for a new modal introduced in #11069 were actually applying to a bunch of other modals

Before:
Screen Shot 2023-02-28 at 5 15 25 PM

After:
Screen Shot 2023-02-28 at 5 15 11 PM

Ticket Link

https://mattermost.atlassian.net/browse/MM-50803

Release Note

NONE

@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Feb 28, 2023
@hmhealey hmhealey added this to the v7.9.0 milestone Feb 28, 2023
@mattermost-build
Copy link
Contributor

E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label.

@github-actions
Copy link

Test Results

       1 files     814 suites   13m 3s ⏱️
6 925 tests 6 924 ✔️ 1 💤 0 ❌
7 101 runs  7 100 ✔️ 1 💤 0 ❌

Results for commit 00e7d93.

nevyangelova
nevyangelova approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@nevyangelova nevyangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@amyblais amyblais requested a review from furqanmlk March 1, 2023 13:39
@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Mar 1, 2023
@furqanmlk furqanmlk added Setup Cloud Test Server Setup a test server using Mattermost Cloud and removed Setup Cloud Test Server Setup a test server using Mattermost Cloud labels Mar 1, 2023
@mm-cloud-bot
Copy link

Test server destroyed

@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023
@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023
@furqanmlk furqanmlk added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023
@mm-cloud-bot
Copy link

Test server creation failed. See the logs for more information.

@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 1, 2023
@furqanmlk
Copy link
Contributor

/e2e-test

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

furqanmlk
furqanmlk approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@furqanmlk furqanmlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected

@amyblais amyblais added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Mar 3, 2023
@hmhealey hmhealey merged commit cba045c into master Mar 3, 2023
@hmhealey hmhealey deleted the MM-50803_modal-buttons branch March 3, 2023 21:50
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@mattermost-build
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the master branch and cleaning up.

hmhealey added a commit that referenced this pull request Mar 3, 2023
@hmhealey
MM-50803 Fix restore post modal styles applying to other modals (#12286)
6a20040
@hmhealey hmhealey mentioned this pull request Mar 3, 2023
Merged
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Mar 3, 2023
mattermost-build pushed a commit that referenced this pull request Mar 3, 2023
@hmhealey
MM-50803 Fix restore post modal styles applying to other modals (#12286…
b6e8156 
…) (#12318)

Automatic Merge
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larkox larkox larkox approved these changes

@furqanmlk furqanmlk furqanmlk approved these changes

@nevyangelova nevyangelova nevyangelova approved these changes

Assignees

@hmhealey hmhealey

Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone Docs/Not Needed Does not require documentation release-note-none
Projects
None yet
Milestone
v7.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@hmhealey @mattermost-build @mm-cloud-bot @furqanmlk @larkox @nevyangelova @amyblais