MM-10268 Count inactive users towards total count in system console user list #1228
Conversation
| teamId = search.team || ''; | ||
|
|
||
| if (!teamId || teamId === SearchUserTeamFilter.ALL_USERS) { | ||
| const stats = state.entities.admin.analytics || {[Stats.TOTAL_USERS]: 0, [Stats.TOTAL_INACTIVE_USERS]: 0}; |
There was a problem hiding this comment.
This should be done through a selector so that it doesn't create a new object each time when state.entities.admin.analytics is empty. Perhaps you could just make a getTotalUsers selector for this page to obscure that logic
There was a problem hiding this comment.
That object isn't getting passed in as a prop, I'm passing in totalUsers as an integer as the prop. I don't think the added complexity of a selector is worth the savings of not creating an object
| } else if (teamId === SearchUserTeamFilter.NO_TEAM) { | ||
| totalUsers = 0; | ||
| } else { | ||
| const stats = state.entities.teams.stats[teamId] || {total_member_count: 0}; |
| @@ -15,6 +15,17 @@ function modalSearch(state = '', action) { | |||
| } | |||
| } | |||
|
|
|||
| function systemUsersSearch(state = {}, action) { | |||
There was a problem hiding this comment.
It might be better to have this under reducers/views/admin.js unless we want open this page to more people
There was a problem hiding this comment.
Meh, I think it doesn't matter that much but if you're more than 0/5 I'll change it
|
@jwilander Needs a rebase |
Summary
Count inactive users towards total count in system console user list. I refactored the system_users component a bit to use more redux patterns.
Ticket Link
https://mattermost.atlassian.net/browse/MM-10268
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed