Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-50417 Fixed centre channel being visible before channels are loaded with GraphQL #12251

Merged
merged 3 commits into from
Mar 3, 2023
Merged

MM-50417 Fixed centre channel being visible before channels are loaded with GraphQL #12251

merged 3 commits into from
Mar 3, 2023

Conversation

hmhealey
Copy link
Member

I changed around how the loading screen that blocks the CenterChannel works in #12058, and for whatever reason, I made it skip the loading screen that's shown while initially loading if GraphQL is enabled. I can't remember exactly why I would've done that, but I must've thought that the user's channels were loaded by this point.

Ticket Link

https://mattermost.atlassian.net/browse/MM-50417

Related Pull Requests

#12058

Release Note

NONE

@hmhealey hmhealey added this to the v7.9.0 milestone Feb 22, 2023
@hmhealey hmhealey requested a review from larkox February 22, 2023 23:09
@hmhealey hmhealey requested a review from a team as a code owner February 22, 2023 23:09
@hmhealey hmhealey requested review from M-ZubairAhmed and removed request for a team February 22, 2023 23:09
@hmhealey hmhealey added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Feb 22, 2023
@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited

Test Results

       1 files     814 suites   14m 26s ⏱️
6 925 tests 6 924 ✔️ 1 💤 0 ❌
7 101 runs  7 100 ✔️ 1 💤 0 ❌

Results for commit 648afc9.

♻️ This comment has been updated with latest results.

@amyblais amyblais modified the milestones: v7.9.0, cloud Feb 22, 2023
@amyblais amyblais added CherryPick/Approved Meant for the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Feb 22, 2023
@amyblais amyblais modified the milestones: cloud, v7.9.0 Feb 22, 2023
larkox
larkox approved these changes Feb 23, 2023
View reviewed changes
package-lock.json Outdated Show resolved Hide resolved
@amyblais amyblais removed this from the v7.9.0 milestone Feb 27, 2023
@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label Feb 27, 2023
@hmhealey
Copy link
Member Author

/e2e-tests

@mattermost-build
Copy link
Contributor

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

@hmhealey hmhealey added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 28, 2023
@mm-cloud-bot mm-cloud-bot removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 28, 2023
@hmhealey hmhealey added the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Feb 28, 2023
stevemudie
stevemudie approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@stevemudie stevemudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all set @hmhealey!
Tested and worked as expected.

@stevemudie stevemudie removed the 3: QA Review Requires review by a QA tester label Mar 3, 2023
@hmhealey hmhealey added the 4: Reviews Complete All reviewers have approved the pull request label Mar 3, 2023
@hmhealey hmhealey merged commit ed4baa6 into master Mar 3, 2023
@hmhealey hmhealey deleted the MM-50417_fix-channel-by-id branch March 3, 2023 21:49
@mattermost-build mattermost-build removed the Setup Cloud Test Server Setup a test server using Mattermost Cloud label Mar 3, 2023
@mm-cloud-bot
Copy link

Test server destroyed

1 similar comment
@mm-cloud-bot
Copy link

Test server destroyed

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@larkox larkox larkox approved these changes

@stevemudie stevemudie stevemudie approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation QA Review Done release-note-none
Projects
None yet
Milestone
No milestone
7 participants
@hmhealey @mattermost-build @mm-cloud-bot @larkox @stevemudie @M-ZubairAhmed @amyblais