This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-10541 Update announcement banner immediately without refresh #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lieut-data
approved these changes
May 9, 2018
|
Good call, I'll add some tests |
hmhealey
approved these changes
May 9, 2018
hmhealey
reviewed
May 9, 2018
| nextProps.bannerColor !== this.props.bannerColor || | ||
| nextProps.bannerTextColor !== this.props.bannerTextColor || | ||
| nextProps.allowBannerDismissal !== this.props.allowBannerDismissal) { | ||
| this.setState(this.getState(nextProps)); |
There was a problem hiding this comment.
This looks like a good place where we could try out https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops :)
hmhealey
added a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
added a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Just needed to update state again when one of the banner settings in the props changed.
The behavior is as follows:
If the banner is being enabled for the first time:
If the banner has not been dismissed by the user:
If the banner has been dismissed by the user:
Ticket Link
https://mattermost.atlassian.net/browse/MM-10541