This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
[MM-10430] Fix behavior of ExperimentalTownSquareIsReadOnly and add ExperimentalHideTownSquareinLHS feature #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2018
|
@saturninoabril, I've removed myself from the reviewers just to clear my |
|
@lieut-data Sure and thanks! This should be good for dev review now. |
hmhealey
approved these changes
May 24, 2018
lieut-data
suggested changes
May 24, 2018
| !isFavoriteChannel(state.entities.preferences.myPreferences, channel.id); | ||
| let shouldHideChannel = false; | ||
| if ( | ||
| Constants.DEFAULT_CHANNEL && |
There was a problem hiding this comment.
I'm a little unclear as to what this is checking -- surely Constants.DEFAULT_CHANNEL is always truthy? Was this meant to be a check against the channel name?
There was a problem hiding this comment.
My mistake. It's check against the channel name. Though the shouldHideDefaultChannel has already that check, it immediately end other conditional checks to non-default channels.
PR updated.
lieut-data
approved these changes
May 24, 2018
…lHideTownSquareinLHS feature
…to make it accessible to mobile RN as well
Signed-off-by: Saturnino Abril <[email protected]>
Signed-off-by: Saturnino Abril <[email protected]>
Signed-off-by: Saturnino Abril <[email protected]>
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix behavior of ExperimentalTownSquareIsReadOnly and add ExperimentalHideTownSquareinLHS feature
ExperimentalTownSquareIsReadOnlyis set to "true", do not automatically hide Town Square channel when it has no unread messages.ExperimentalHideTownSquareinLHSis set to "true", Town Square channel will be hidden when there are no unread messages. The channel should still be accessible via CTRL/CMD+Kand the "More Channels" menus.(Note: Will update commit of this PR once server and redux changes are merged)
@jasonblais @esethna @amyblais I'd like to request for your quick check once the server and redux PRs are merged - just to make sure that all are covered. Thanks!
Ticket Link
Jira ticket: [MM-10430]
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed