Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Fix incorrect post date when data retention has deleted root. #1189

Merged
merged 1 commit into from
May 8, 2018
Merged

Fix incorrect post date when data retention has deleted root. #1189

merged 1 commit into from
May 8, 2018

Conversation

mkraft
Copy link
Contributor

@mkraft mkraft commented May 8, 2018

Summary

Wrong substitute value was being used for rootPostDay when data retention deleted the root post.

Ticket Link

Release 4.10 bug.

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has UI changes

@mkraft mkraft added the 2: Dev Review Requires review by a core commiter label May 8, 2018
@mkraft mkraft requested review from jespino and grundleborg May 8, 2018 13:36
@mkraft mkraft changed the title Fix incorrect post date for rootPostDay. Fix incorrect post date when data retention has deleted root. May 8, 2018
jespino
jespino approved these changes May 8, 2018
View reviewed changes
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Took me some time to understand why the "lenght - 1". But makes sense because this.props.posts have inverse order.

@mkraft mkraft merged commit 4368605 into release-4.10 May 8, 2018
@jasonblais jasonblais modified the milestones: v4.11.0, v4.10.0 May 8, 2018
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels May 8, 2018
@mkraft mkraft deleted the MM-9924 branch May 9, 2018 19:09
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label May 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jespino jespino jespino approved these changes

@grundleborg grundleborg grundleborg approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core commiter Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Milestone
v4.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@mkraft @jespino @grundleborg @jasonblais @lindalumitchell @amyblais