This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Apps - Allow call response "navigate" on apps modal form submit #11707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
added
2: Dev Review
|
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label. |
levb
approved these changes
Dec 2, 2022
|
Note that this is already working correctly on mobile |
larkox
approved these changes
Dec 7, 2022
|
@DHaussermann I've tested this manually and it's working properly. There's very low risk here, thoughts on merging at its current review state? |
|
/update-branch |
|
@DHaussermann I've tested this manually and it's working properly. There's very low risk here, thoughts on merging at its current review state? |
|
/cherry-pick cloud |
|
Cherry pick is scheduled. |
mattermost-build
pushed a commit
to mattermost-build/mattermost-webapp
that referenced
this pull request
Feb 17, 2023
) Co-authored-by: Mattermost Build <[email protected]> (cherry picked from commit 7a2feaa)
mattermost-build
added
the
CherryPick/Done
amyblais
pushed a commit
that referenced
this pull request
Feb 17, 2023
Co-authored-by: Mattermost Build <[email protected]> (cherry picked from commit 7a2feaa) Co-authored-by: Michael Kochell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it so Apps modal form submit response can be type
navigate. Before this PR, the client successfully navigates, but the modal also shows an error.Ticket Link
https://mattermost.atlassian.net/browse/MM-48816
Release Note