Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-10431 - Updating UI for post controls #1154

Merged
merged 1 commit into from
May 3, 2018
Merged

MM-10431 - Updating UI for post controls #1154

merged 1 commit into from
May 3, 2018

Conversation

asaadmahmood
Copy link
Contributor

@asaadmahmood asaadmahmood commented May 2, 2018

Summary

MM-10431 - Updating UI for post controls

Ticket Link

https://mattermost.atlassian.net/browse/MM-10431

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed
  • Added or updated unit tests (required for all new features)
  • Has server changes (please link)
  • Has redux changes (please link)
  • Has UI changes
  • Includes text changes and localization file (.../i18n/en.json) updates
  • Touches critical sections of the codebase (auth, posting, etc.)

Before:
screen shot 2018-05-02 at 2 01 06 pm

After:
screen shot 2018-05-02 at 1 53 23 pm

@jasonblais jasonblais added the 2: Dev Review Requires review by a core commiter label May 2, 2018
@jasonblais
Copy link
Contributor

@asaadmahmood This is because the [...] is missing. https://mattermost.atlassian.net/browse/MM-10324

Not sure if we want to make this change regardless though.

@hmhealey
Copy link
Member

hmhealey commented May 2, 2018

As long as it still looks correct with all 3 icons, we could take it. It's possible to end up with only 2 icons there when you're in the town square with the read only mode turned on.

@jasonblais jasonblais added this to the v4.10.0 milestone May 2, 2018
Copy link
Member

@saturninoabril saturninoabril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It feels weird to see a large space in between of those icons.

@asaadmahmood
Copy link
Contributor Author

@jasonblais I know, but that exactly is what is messing it up, it is changing the position of the emoji reactions and adding a weird space.

@asaadmahmood
Copy link
Contributor Author

And yes it looks correct with those 3 buttons.
screen shot 2018-05-02 at 10 29 47 pm

@hmhealey hmhealey removed the 2: Dev Review Requires review by a core commiter label May 3, 2018
@hmhealey hmhealey merged commit c6e5046 into mattermost:master May 3, 2018
@amyblais amyblais added Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation labels May 3, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label May 4, 2018
@asaadmahmood asaadmahmood deleted the mm-10431 branch May 9, 2018 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog/Done Required changelog entry has been written Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
6 participants