Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Change Total Users --> Total Active Users in System Console statistics pages #1110

Merged
merged 3 commits into from
Apr 18, 2018

Conversation

jasonblais
Copy link
Contributor

Summary

Change Total Users --> Total Active Users in System Console statistics pages.

At the moment it's not obvious that "Total Users" doesn't include deactivated users. Some customers don't know it's a net active user count when figuring out the required license count for purchase or renewal.

Checklist

@jasonblais jasonblais added the 1: PM Review Requires review by a product manager label Apr 18, 2018
@jasonblais jasonblais self-assigned this Apr 18, 2018
@jasonblais jasonblais added 2: Dev Review Requires review by a core commiter and removed 1: PM Review Requires review by a product manager labels Apr 18, 2018
@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Apr 18, 2018
@jwilander
Copy link
Member

@jasonblais only concern is that the text might wrap now and look weird next to the other stats

@jasonblais
Copy link
Contributor Author

@jwilander Yeah I checked and not an issue as it doesn't wrap for Monthly Active Users.

image

@mattermod
Copy link
Contributor

Setup Test Server label detected. Spinmint test server created if build succeeds (checks pass and no conflicts with base branch).

@jasonblais jasonblais added the Setup Old Test Server Triggers the creation of a test server label Apr 18, 2018
@jasonblais
Copy link
Contributor Author

I'll spin up a test server just to test it out and confirm

@mattermod
Copy link
Contributor

Spinmint test server created at: https://i-03ae304dd05af33c5.spinmint.com

Test Admin Account: Username: sysadmin | Password: sysadmin

Test User Account: Username: user-1 | Password: user-1

Instance ID: i-03ae304dd05af33c5

@jasonblais
Copy link
Contributor Author

Confirmed. Also same length as "Daily Active Users" so we should be ok

image

@jasonblais jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Apr 18, 2018
@mattermod
Copy link
Contributor

Spinmint test server destroyed

@jasonblais jasonblais removed their assignment Apr 18, 2018
@jwilander
Copy link
Member

Haha I would have accepted a simple "It's good" :P

@jwilander jwilander merged commit b0cfc55 into master Apr 18, 2018
@jwilander jwilander deleted the jasonblais-patch-1 branch April 18, 2018 15:53
@jasonblais
Copy link
Contributor Author

Haha, fair enough

@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Apr 18, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Apr 25, 2018
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
MM-23542: declare new permission PERMISSION_ACCESS_SYSTEM_CONSOLE
hmhealey pushed a commit that referenced this pull request Aug 28, 2020
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
MM-23542: declare new permission PERMISSION_ACCESS_SYSTEM_CONSOLE
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants