Changes for Town Square read only on web small screen size. Overlay m…

[csduarte]

Summary

These changes when "ExperimentalTownSquareIsReadOnly": true. for TownSquare for small screen size:

• hide the edit able elements in the overlay menu options.
• hide Click here to add one. Header in the Info overlay.

They were missed on the original changes to:
Hide edit able elements for Town Square in Channel View.
bafea1d

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• Ran make check-style to check for style errors (required for all pull requests)
• Ran make test to ensure unit and component tests passed
• Has UI changes
• Includes text changes and localization file ([.../i18n/en.json] updates

via @dmeza

[dmeza]

@jasonblais these are changes that were missed on the first pass:

[jasonblais]

@dmeza Three notes

1 - The "Add Members" option for channels now says to add one.

2 - Can we remove the ... for posts in mobile view when the menu has nothing? In the attached, if I click ... on the system message, a blank menu opens (since there are no options to display given they're all hidden)

3 - How do I get to this screen? I wasn't able to find it

[dmeza]

@jasonblais rebased to lastes.
1 - is fixed
2 - is fixed. It seems it was an existing bug. It wasn't related to these changes.
3 - when "ExperimentalTownSquareIsReadOnly": true (with a license enabled). It should display like that on Town Square.
Fixed tests.

[jasonblais]

Thank you!

[hmhealey]

I don't think this shouldn't be inside this if statement or else you won't be able to leave a read only channel that isn't the town square (assuming we ever support those)

[hmhealey]

Instead of concatenating the sentence, can you structure it like this so that the translator has more control over the sentence?

addOne = (
    <div>
        <FormattedMessage
            id='navbar.clickToAddHeader'
            defaultMessage='{clickHere} to add one.'
            values={{
                clickHere: link
            }}
        />
    </div>
);

[hmhealey]

I don't think this div is necessary, but if you want to maintain the original spacing, you could use

addOne = (
    <React.Fragment>
        <br/>
        <FormattedMessage .../>
    </React.Fragment>
);

[dmeza]

@hmhealey rebased to latest from master and made the changes requested.

[hmhealey]

The defaultMessage uses {link} instead of {clickHere}. Otherwise, it looks good

[dmeza]

@hmhealey rebased and made the change.