This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Support hiding plugin settings based on hosting environment #10799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
added
2: Dev Review
|
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label. |
This was referenced Jul 19, 2022
For non-cloud plugin settings, set hosting property to
on-prem
mattermost/mattermost-plugin-zoom#269
Merged
|
/update-branch |
DHaussermann
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Tested and passed testing done deployed alongside mattermost/mattermost#20677
LGTM!
DHaussermann
added
QA Review Done
and removed
3: QA Review
catalintomai
approved these changes
Jul 25, 2022
larkox
approved these changes
Jul 26, 2022
larkox
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes it so a given plugin can hide specific plugin settings based on the hosting environment of the server.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-44843
Related Pull Requests
on-premmattermost-plugin-zoom#269Release Note