This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Show desktop app download prompt on first visit to a new server #10573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevyangelova
added
2: Dev Review
|
E2E tests not automatically triggered, because PR has no approval yet. Please ask a developer to review and then try again to attach the QA label. |
devinbinnie
approved these changes
Jun 13, 2022
calebroseland
approved these changes
Jun 14, 2022
calebroseland
added
3: QA Review
|
Successfully triggered e2e testing! |
nevyangelova
added
the
QA Deferred
|
Successfully triggered e2e testing! |
amyblais
added
Changelog/Not Needed
saturninoabril
added a commit
that referenced
this pull request
Aug 3, 2022
#10653) * Show desktop app download prompt on first visit to a new server * Exclude test urls * Fix e2e cypress * sanitize url * Fix for desktop app * add check for reload as well * Update specs * remve before all * clean up on test file Co-authored-by: Nevyana Angelova <[email protected]> Co-authored-by: Saturnino Abril <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the functionality to preview the desktop app download screen on a first visit to a new server.
Steps:
Ticket Link
https://mattermost.atlassian.net/browse/MM-36439
Screenshots
Release Note