This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
MM-9973: ignore dispatched events against unregistered suggestion boxes #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a slow network environment, typing a channel name, then erasing it, then quickly typing again and hitting enter to unmount the suggestion box could result in a previous network call eventually dispatching an event for the now unregistered suggestion box. If the dispatched event was for an empty string, it would incorrectly try to handle that, ultimately attempting to dereference `undefined.push`.
jwilander
approved these changes
Apr 5, 2018
hmhealey
approved these changes
Apr 5, 2018
amyblais
added
4: Reviews Complete
mkraft
approved these changes
Apr 5, 2018
GoldUniform
deleted the
MM-9973-handle-late-events-to-unregistered-suggestion-box
branch
amyblais
added
Changelog/Done
hmhealey
added a commit
that referenced
this pull request
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a slow network environment, typing a channel name, then erasing it,
then quickly typing again and hitting enter to unmount the suggestion
box could result in a previous network call eventually dispatching an
event for the now unregistered suggestion box. If the dispatched event
was for an empty string, it would incorrectly try to handle that,
ultimately attempting to dereference
undefined.push.Ticket Link
https://mattermost.atlassian.net/browse/MM-9973
Checklist
make check-styleto check for style errors (required for all pull requests)make testto ensure unit and component tests passed