Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Eliminate yarn test spam #1024

Merged
merged 13 commits into from
Apr 3, 2018
Merged

Eliminate yarn test spam #1024

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3604978
remove "Network status set to (true|false)" message
lieut-data Mar 27, 2018
d548f3d
work around UnhandledPromiseRejectionWarning errors from localforage
lieut-data Mar 28, 2018
c99562f
fix missing props in tests
lieut-data Mar 28, 2018
73b5fcb
skip passing showEmailAddress from ProfilePopver to the Popover boots…
lieut-data Mar 28, 2018
b331b43
eliminate unneeded warning in getPrefix
lieut-data Mar 28, 2018
9a49fde
fix spurious state in rhs reducer tests
lieut-data Mar 28, 2018
dc6d2a4
leverage jest-canvas-mock to avoid warnings from the doughnut chart
lieut-data Mar 28, 2018
b7c99d9
fail the build on console messages
lieut-data Mar 28, 2018
ab47e5b
Revert "skip passing showEmailAddress from ProfilePopver to the Popov…
lieut-data Apr 3, 2018
688c6b8
just remove showEmailAddress in the profile popover unit tests
lieut-data Apr 3, 2018
7642e80
define STORE_REHYDRATION_FAILED locally vs. in mattermost-redux, for now
lieut-data Apr 3, 2018
e480ec1
Merge remote-tracking branch 'origin/master' into eliminate-yarn-test…
lieut-data Apr 3, 2018
b209749
fix recently broken unit tests
lieut-data Apr 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
skip passing showEmailAddress from ProfilePopver to the Popover boots… 
…trap component
  • Loading branch information
@lieut-data
lieut-data committed Mar 28, 2018
commit 73b5fcbc03dd12b41063c4cbd84bcfb97b748d2b
1 change: 1 addition & 0 deletions components/profile_popover/profile_popover.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ class ProfilePopover extends React.Component {
delete popoverProps.hasMention;
delete popoverProps.dispatch;
delete popoverProps.enableWebrtc;
delete popoverProps.showEmailAddress;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Injected by the connector but wasn't removed, like enableWebrtc, and ended up incorrectly as a DOM property.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are not using showEmailAddress at all, so, the solution would be remove that from the connect function.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, I like that better -- somehow, I thought this was being passed in via a plugin, but you're right that it's only part of the pluggable unit tests.


let webrtc;
const userMedia = navigator.getUserMedia || navigator.webkitGetUserMedia || navigator.mozGetUserMedia;
Expand Down
2 changes: 0 additions & 2 deletions tests/plugins/__snapshots__/pluggable.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,13 @@ exports[`plugins/Pluggable should match snapshot with no overridden component 1`
bsClass="popover"
id="user-profile-popover"
placement="right"
showEmailAddress={true}
theme={Object {}}
title="@undefined"
>
<div
className="popover right"
id="user-profile-popover"
role="tooltip"
showEmailAddress={true}
style={
Object {
"display": "block",
Expand Down