Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

MM-9787: remove redundant class manipulation, now handled by Redux #1011

Merged
merged 1 commit into from
Mar 28, 2018

Conversation

lieut-data
Copy link
Member

@lieut-data lieut-data commented Mar 27, 2018

Summary

This was missed in the original changes for this feature, helpfully pointed out by @koxen.

Ticket Link

https://mattermost.atlassian.net/browse/MM-8787

Checklist

  • Ran make check-style to check for style errors (required for all pull requests)
  • Ran make test to ensure unit and component tests passed

This was missed in the original changes for this feature, helpfully
pointed out by @koxen.
@lieut-data lieut-data added the 2: Dev Review Requires review by a core commiter label Mar 27, 2018
Copy link
Member

@jespino jespino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grundleborg grundleborg added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Mar 27, 2018
@lieut-data lieut-data merged commit 2d9828a into master Mar 28, 2018
@lieut-data lieut-data deleted the MM-9787-missing-manual-class-removal branch March 28, 2018 13:19
@amyblais amyblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation labels Mar 28, 2018
@lindalumitchell lindalumitchell added the Tests/Not Needed Does not require new release tests label Mar 28, 2018
hmhealey pushed a commit that referenced this pull request Mar 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed Does not require new release tests
Projects
None yet
5 participants