This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Removing pure components from gates #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jespino
requested review from
grundleborg and
mkraft
and removed request for
grundleborg
mkraft
reviewed
Mar 26, 2018
There was a problem hiding this comment.
I'm just wondering if this change would remove the ability to do something like this where the children are set as a constant in the parent component? If it's a PureComponent I think it would be able to utilize that optimization.
|
Yes, you are right but I'm not sure about how often can we use that, because an static component doesn't use any props from the parent, if they are things that we can build from the ComponentDidMount or things like that, it is ok, but more than that, I think will be complicated to maintain as an not-changing object. |
grundleborg
approved these changes
Mar 27, 2018
grundleborg
added
4: Reviews Complete
|
@jespino Can you help update the base branch now that phase 1 permissions is merged? |
|
Done! :) |
jespino
force-pushed
the
removed-pure-componens-from-gates
branch
from
c3aded2
to
ad6baa2
Compare
jespino
force-pushed
the
removed-pure-componens-from-gates
branch
from
ad6baa2
to
99d96fb
Compare
|
Rebased and tests passing :) |
amyblais
added
Changelog/Not Needed
hmhealey
pushed a commit
that referenced
this pull request
Aug 28, 2020
…1004) * adding undelete action * fix lint * adding undelete * remove delete_at * add entities reducers test for unarchive * fix actions test * add post tests * undeleted to restored * change undelete to unarchive * fix tests * suggested changes * clean up * use getConfig
hmhealey
pushed a commit
that referenced
this pull request
Mar 17, 2021
…1004) * adding undelete action * fix lint * adding undelete * remove delete_at * add entities reducers test for unarchive * fix actions test * add post tests * undeleted to restored * change undelete to unarchive * fix tests * suggested changes * clean up * use getConfig
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically PureComponent is not really needed, because the children prop will be
almost alwais a new object, so will rerender almost every single time, so we
can skip the props comparison.