Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Commit

Permalink
[MM-28328][MM-28329] Click "Getting Started" in lower LHS to go back …
Browse files Browse the repository at this point in the history
…to Next Steps View (#6384)

* Click 'Getting Started' in lower LHS to go to getting started modal

* Fix pipeline

* Revert package-lock

* Persistence for Tips & Next Steps lower LHS, and same click to open functionality

* Remove commented code

* Add hover tint for section

* Add spaces

* revert package-lock

* Update components/next_steps_view/next_steps_view.tsx

Co-authored-by: Ali Farooq <[email protected]>

* Remove important, use variable instead of 255x3

Co-authored-by: Ali Farooq <[email protected]>
  • Loading branch information
nickmisasi and alifarooq0 committed Sep 8, 2020
1 parent 81b3f43 commit d06568e
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 21 deletions.
9 changes: 9 additions & 0 deletions components/next_steps_view/next_steps_view.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ export default class NextStepsView extends React.PureComponent<Props, State> {
};
}

showFinalScreenNoAnimation = () => {
this.setState({showFinalScreen: true});
}

showFinalScreen = () => {
this.setState({showFinalScreen: true, animating: true});
}
Expand Down Expand Up @@ -208,6 +212,11 @@ export default class NextStepsView extends React.PureComponent<Props, State> {
renderMainBody = () => {
const renderedSteps = this.props.steps.map(this.renderStep);

// If all steps are complete, don't render this and skip to the tips screen
if (this.getIncompleteStep() === null) {
this.showFinalScreenNoAnimation();
return null;
}
return (
<div
className={classNames('NextStepsView__viewWrapper NextStepsView__mainView', {
Expand Down
5 changes: 5 additions & 0 deletions components/sidebar/sidebar_next_steps/sidebar_next_steps.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@
align-self: flex-end;
position: relative;
background-color: var(--sidebar-bg);
cursor: pointer;

&:hover:not(.active) {
background-color: rgba(var(--button-color-rgb), 0.08);
}

&.active {
background-color: var(--sidebar-text-hover-bg);
Expand Down
38 changes: 18 additions & 20 deletions components/sidebar/sidebar_next_steps/sidebar_next_steps.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ export default class SidebarNextSteps extends React.PureComponent<Props, State>
};
}

closeNextSteps = () => {
closeNextSteps = (event: React.SyntheticEvent) => {
event.stopPropagation();
const screenTitle = this.props.showNextSteps ?
localizeMessage('sidebar_next_steps.gettingStarted', 'Getting Started') :
localizeMessage('sidebar_next_steps.tipsAndNextSteps', 'Tips & Next Steps');
Expand All @@ -63,6 +64,10 @@ export default class SidebarNextSteps extends React.PureComponent<Props, State>
});
}

showNextSteps = () => {
this.props.actions.setShowNextStepsView(true);
}

onCloseModal = () => {
this.props.actions.closeModal(ModalIdentifiers.REMOVE_NEXT_STEPS_MODAL);
}
Expand All @@ -85,10 +90,6 @@ export default class SidebarNextSteps extends React.PureComponent<Props, State>
return null;
}

if (!this.props.active && !this.props.showNextSteps) {
return null;
}

const total = this.props.steps.length;
const complete = this.props.preferences.filter((pref) => pref.name !== RecommendedNextSteps.HIDE && pref.value === 'true').length;

Expand Down Expand Up @@ -125,17 +126,15 @@ export default class SidebarNextSteps extends React.PureComponent<Props, State>
/>
);
}

return (
<div
className={classNames('SidebarNextSteps', {
active: this.props.active,
})}
onClick={this.showNextSteps}
>
<div className='SidebarNextSteps__top'>
<span>
{header}
</span>
<span>{header}</span>
<button
className='SidebarNextSteps__close'
onClick={this.closeNextSteps}
Expand All @@ -144,18 +143,17 @@ export default class SidebarNextSteps extends React.PureComponent<Props, State>
</button>
</div>
<div className='SidebarNextSteps__middle'>
<span>
{middleSection}
</span>
<span>{middleSection}</span>
</div>
{this.props.showNextSteps &&
<div className='SidebarNextSteps__progressBar'>
<ProgressBar
current={complete}
total={total}
basePercentage={4}
/>
</div>}
{this.props.showNextSteps && (
<div className='SidebarNextSteps__progressBar'>
<ProgressBar
current={complete}
total={total}
basePercentage={4}
/>
</div>
)}
</div>
);
}
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit d06568e

Please sign in to comment.