Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Commit

Permalink
Minor bug fixes (#182)
Browse files Browse the repository at this point in the history
* PLT-7838 - Increasing whitespace above embed

* PLT-7841 - Switch channel button style issue

* PLT-7948 - Post control menu background fix mobile

* PLT-7835 - Updating position of reply icon

* PLT-7282 - Updating user list styling
  • Loading branch information
asaadmahmood authored and jwilander committed Oct 25, 2017
1 parent 2fdb712 commit c8ae25a
Show file tree
Hide file tree
Showing 5 changed files with 73 additions and 9 deletions.
3 changes: 1 addition & 2 deletions sass/components/_modal.scss
Original file line number Diff line number Diff line change
Expand Up @@ -622,15 +622,14 @@
}

.more-modal__name {
font-size: .95em;
font-weight: 600;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

.more-modal__description {
@include opacity(.7);
@include opacity(.6);
display: block;
overflow: hidden;
text-overflow: ellipsis;
Expand Down
1 change: 1 addition & 0 deletions sass/layout/_post.scss
Original file line number Diff line number Diff line change
Expand Up @@ -1205,6 +1205,7 @@
.post__embed-container {
@include single-transition(max-height, .5, ease);
display: block;
margin-top: 5px;
max-height: 1000px;
overflow: hidden;

Expand Down
2 changes: 1 addition & 1 deletion sass/layout/_sidebar-left.scss
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
width: 100%;

button {
@include single-transition(all, .15s, ease-in);
background: transparent;
display: block;
font-weight: 600;
height: 45px;
Expand Down
47 changes: 46 additions & 1 deletion sass/responsive/_mobile.scss
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,14 @@
}
}

&.post--system {
.post__header {
.col__reply {
min-width: 70px;
}
}
}

.reacticon__container {
display: none;
}
Expand Down Expand Up @@ -341,6 +349,26 @@
padding: 0 10px 0 0;
}

&.current--user {
.post__header {
margin-bottom: 7px;
}

&.same--root {
&.same--user {
.post__header {
margin-bottom: 7px;
}
}
}

&.post--comment {
.post__header {
margin-bottom: 3px;
}
}
}

.post__header {
margin-bottom: 0;
padding-right: 70px;
Expand Down Expand Up @@ -410,7 +438,7 @@
&.post--comment {
.post__header {
.col__reply {
top: -3px;
top: -6px;
}
}
}
Expand Down Expand Up @@ -1373,6 +1401,23 @@
}

@media screen and (max-width: 640px) {
.col__reply {
.dropdown-menu {
> li {
> button {
border-top: 1px solid;
padding: 15px 20px;
}

&:first-child {
button {
border: none;
}
}
}
}
}

.filtered-user-list {
height: calc(100vh - 80px);
}
Expand Down
29 changes: 24 additions & 5 deletions utils/utils.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ export function applyTheme(theme) {
changeCss('.app__body .sidebar--left .sidebar__switcher', 'border-color:' + changeOpacity(theme.sidebarText, 0.2));
changeCss('@media(max-width: 768px){.sidebar--left .add-channel-btn:hover, .sidebar--left .add-channel-btn:focus', 'color:' + changeOpacity(theme.sidebarText, 0.6));
changeCss('@media(max-width: 768px){.app__body .search__icon svg', 'stroke:' + theme.sidebarText);
changeCss('.app__body .sidebar--left .sidebar__switcher button', 'color:' + theme.sidebarText);
changeCss('.app__body .sidebar--left .sidebar__switcher span', 'color:' + theme.sidebarText);
changeCss('.app__body .sidebar--left .sidebar__switcher button svg', 'fill:' + theme.sidebarText);
changeCss('.app__body .sidebar__switcher button', 'background:' + changeOpacity(theme.sidebarText, 0.08));
}
Expand Down Expand Up @@ -588,6 +588,7 @@ export function applyTheme(theme) {
}

if (theme.centerChannelBg) {
changeCss('@media(max-width: 640px){.app__body .post .dropdown .dropdown-menu button', 'background:' + theme.centerChannelBg);
changeCss('@media(min-width: 768px){.app__body .post:hover .post__header .col__reply, .app__body .post.post--hovered .post__header .col__reply', 'background:' + theme.centerChannelBg);
changeCss('@media(max-width: 320px){.tutorial-steps__container', 'background:' + theme.centerChannelBg);
changeCss('.app__body .channel-header__info .channel-header__description:before, .app__body .app__content, .app__body .markdown__table, .app__body .markdown__table tbody tr, .app__body .suggestion-list__content, .app__body .modal .modal-content, .app__body .modal .modal-footer, .app__body .post.post--compact .post-image__column, .app__body .suggestion-list__divider > span, .app__body .status-wrapper .status, .app__body .alert.alert-transparent', 'background:' + theme.centerChannelBg);
Expand All @@ -612,7 +613,7 @@ export function applyTheme(theme) {

if (theme.centerChannelColor) {
changeCss('.app__body .mentions__name .status.status--group, .app__body .multi-select__note', 'background:' + changeOpacity(theme.centerChannelColor, 0.12));
changeCss('.app__body .member-list__popover .more-modal__body, .app__body .alert.alert-transparent, .app__body .channel-header .channel-header__icon, .app__body .search-bar__container .search__form, .app__body .table > thead > tr > th, .app__body .table > tbody > tr > td', 'border-color:' + changeOpacity(theme.centerChannelColor, 0.12));
changeCss('.app__body .post .dropdown .dropdown-menu button, .app__body .member-list__popover .more-modal__body, .app__body .alert.alert-transparent, .app__body .channel-header .channel-header__icon, .app__body .search-bar__container .search__form, .app__body .table > thead > tr > th, .app__body .table > tbody > tr > td', 'border-color:' + changeOpacity(theme.centerChannelColor, 0.12));
changeCss('.app__body .post-list__arrows, .app__body .post .flag-icon__container', 'fill:' + changeOpacity(theme.centerChannelColor, 0.3));
changeCss('@media(min-width: 768px){.app__body .search__icon svg', 'stroke:' + changeOpacity(theme.centerChannelColor, 0.4));
changeCss('.app__body .channel-header__icon svg', 'fill:' + changeOpacity(theme.centerChannelColor, 0.4));
Expand Down Expand Up @@ -1058,11 +1059,29 @@ export function displayEntireNameForUser(user) {
const fullName = getFullName(user);

if (fullName && user.nickname) {
displayName += ` - ${fullName} (${user.nickname})`;
displayName = (
<span>
{'@' + user.username}
{' - '}
<span className='light'>{fullName + ' (' + user.nickname + ')'}</span>
</span>
);
} else if (fullName) {
displayName += ` - ${fullName}`;
displayName = (
<span>
{'@' + user.username}
{' - '}
<span className='light'>{fullName}</span>
</span>
);
} else if (user.nickname) {
displayName += ` - ${user.nickname}`;
displayName = (
<span>
{'@' + user.username}
{' - '}
<span className='light'>{'(' + user.nickname + ')'}</span>
</span>
);
}

return displayName;
Expand Down

0 comments on commit c8ae25a

Please sign in to comment.