Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Commit

Permalink
Fix Cannot read property "window" of undefined (#4872)
Browse files Browse the repository at this point in the history
I have no good way of testing this without enterprise code to build, but with SAML enabled on our build we get an error on line 1 of a js bundle.

```
Cannot read property 'window' of undefined
```

Looking through the bundles that are being loaded, I noticed that this controller looked interesting. And I noticed there was one call to window that did not reference `global` and it was only when SAML was enabled. So it seems to match like a good puzzle piece. 

Happy to get some help debugging this if I'm totally wrong in this.
  • Loading branch information
csduarte authored and jwilander committed Dec 22, 2016
1 parent dc5f25f commit c0e4365
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion components/login/login_controller.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ export default class LoginController extends React.Component {
>
<span className='icon fa fa-lock fa--margin-top'/>
<span>
{window.mm_config.SamlLoginButtonText}
{global.window.mm_config.SamlLoginButtonText}
</span>
</a>
);
Expand Down

0 comments on commit c0e4365

Please sign in to comment.