This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
MM-17468 - Improving performance of fetching threads #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2019
jespino
reviewed
Aug 29, 2019
jespino
reviewed
Aug 29, 2019
jespino
reviewed
Aug 29, 2019
jespino
suggested changes
Aug 29, 2019
lieut-data
suggested changes
Aug 30, 2019
lieut-data
added
3: QA Review
and removed
2: Dev Review
lieut-data
approved these changes
Sep 5, 2019
lieut-data
added a commit
that referenced
this pull request
Sep 27, 2019
This reverts commit ae457c3.
lieut-data
added a commit
that referenced
this pull request
Sep 30, 2019
Willyfrog
added a commit
to Willyfrog/mattermost-redux
that referenced
this pull request
Nov 27, 2019
Willyfrog
added a commit
to Willyfrog/mattermost-redux
that referenced
this pull request
Nov 27, 2019
Willyfrog
added a commit
that referenced
this pull request
Nov 28, 2019
* Revert "MM-18623 - Handle reply-count in getPostThread code path (#933)" This reverts commit 74018c6. * Revert "MM-17468 - Fix regression. Maintain reply_count on parent post w… (#928)" This reverts commit 4a749d7. * Revert "MM-17468 - Improving performance of fetching threads (#911)" This reverts commit ae457c3. * prevent circle from changing package-lock on install
reflog
added a commit
that referenced
this pull request
Jan 14, 2020
* Revert "refactored into two separate components. cleaned up css" This reverts commit 6784589 * Revert "MM-17468 - Improving performance of fetching threads (#911)" This reverts commit ae457c3. * Revert "MM-17468 - Fix regression. Maintain reply_count on parent post w… (#928)" This reverts commit 4a749d7. * Revert "MM-18623 - Handle reply-count in getPostThread code path (#933)" This reverts commit 74018c6.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a
fetchThreadsparameter to determine if the full thread is fetched with post queries, or just the post + root (to update the reply count / show theCommented on...prefix.Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-17468
Related Pull Requests
mattermost/mattermost#11980
mattermost/mattermost-webapp#3549
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
make check-styleto check for style errors (required for all pull requests)make testto ensure unit tests passedmake flowto ensure type checking passedTest Information
This PR was tested on: [Device name(s), OS version(s)]
Ubuntu 19.04