Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

ABC-79: add autocomplete channels endpoint #384

Merged
merged 3 commits into from
Jan 31, 2018
Merged

ABC-79: add autocomplete channels endpoint #384

merged 3 commits into from
Jan 31, 2018

Conversation

ccbrown
Copy link
Contributor

@ccbrown ccbrown commented Jan 30, 2018

@ccbrown ccbrown added the 2: Dev Review Requires review by a core commiter label Jan 30, 2018
@ccbrown ccbrown mentioned this pull request Jan 30, 2018
Merged
4 tasks
jwilander
jwilander suggested changes Jan 30, 2018
View reviewed changes
src/actions/channels.js
@@ -808,6 +808,37 @@ export function getChannels(teamId, page = 0, perPage = General.CHANNELS_CHUNK_S
};
}

export function autocompleteChannels(teamId, term) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test for this action?

Copy link
Contributor Author

@ccbrown ccbrown Jan 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩 You caught me. I went to copy and paste the "searchChannels" unit test, saw that there wasn't one, and thought "This looks hard...". (Yeah, I'll go add one now.)

@ccbrown
Copy link
Contributor Author

ccbrown commented Jan 30, 2018

@jwilander Added test.

jwilander
jwilander approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@jwilander jwilander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good but you've got a style error:

/home/ubuntu/jenkins/workspace/mattermost-redux-pr/src/github.com/mattermost/mattermost-redux/test/actions/channels.test.js
  1803:17  error  Strings must use singlequote  quotes

✖ 1 problem (1 error, 0 warnings)

@jwilander jwilander added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core commiter labels Jan 31, 2018
@jwilander jwilander merged commit ed1d042 into mattermost:master Jan 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grundleborg grundleborg grundleborg approved these changes

@jwilander jwilander jwilander approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ccbrown @grundleborg @jwilander