Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

MM-28733 : Admin Advisor v2 #1237

Closed
wants to merge 2 commits into from

Conversation

catalintomai
Copy link
Contributor

@catalintomai catalintomai commented Sep 16, 2020

@amyblais amyblais removed the 2: Dev Review Requires review by a core commiter label Sep 18, 2020
@catalintomai catalintomai removed this from the v5.28 milestone Sep 20, 2020
@catalintomai
Copy link
Contributor Author

catalintomai commented Sep 20, 2020

This PR is not relevant anymore after PM spec updates - banner advisories action is "Contact Us" for both TE and E0, not "Start Trial" for E0 and "Contact Us" for TE. Will be closed after the other PRs for this feature get in.

Copy link
Contributor

@srkgupta srkgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the updated PR along with it's dependent PRs and all the issues are now fixed and are working fine. Approving the PR.

@srkgupta srkgupta added the 4: Reviews Complete All reviewers have approved the pull request label Sep 24, 2020
@catalintomai
Copy link
Contributor Author

Cleaning up obsolete PRs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants