This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
[MM-22276] Add roles constants #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mkraft
reviewed
Feb 28, 2020
mkraft
approved these changes
Mar 4, 2020
srkgupta
approved these changes
Mar 5, 2020
There was a problem hiding this comment.
Thanks @hahmadia . The changes are looking good. The PR has been tested on localhost along with it's dependent server and webapp PR and it LGTM. Approving the PR.
QA Notes: Testcases have been added at the epic level for this feature in the release spreadsheet & JIRA.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This ticket is a part of mattermost/mattermost-webapp#4881 where it was suggested to create a constants for roles.