Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for clients to check the bots and oauth apps ids #138

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Apr 9, 2021

Summary

Add API for clients to check the bots and oauth apps ids

Ticket Link

https://mattermost.atlassian.net/browse/MM-33158

Related pull requests

Webapp: mattermost/mattermost-webapp#7850

@larkox larkox added the 2: Dev Review Requires review by a core committer label Apr 9, 2021
@larkox larkox requested review from levb and catalintomai April 9, 2021 12:05
@codecov-io
Copy link

codecov-io commented Apr 9, 2021

Codecov Report

Merging #138 (34385d7) into master (6b25485) will increase coverage by 0.05%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   20.60%   20.65%   +0.05%     
==========================================
  Files          28       29       +1     
  Lines        1291     1307      +16     
==========================================
+ Hits          266      270       +4     
- Misses       1007     1019      +12     
  Partials       18       18              
Impacted Files Coverage Δ
server/http/restapi/get_ids.go 0.00% <0.00%> (ø)
server/http/restapi/restapi.go 84.37% <100.00%> (+2.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b25485...34385d7. Read the comment docs.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0/5 Maybe the API endpoints should take into account that the API might have to be enhanced in the future. Do we need a struct that contains the data instead of a list?

@larkox
Copy link
Contributor Author

larkox commented Apr 12, 2021

I prefer the simplest the better, but you are right that having this in a struct may make this more expandable. Worst case scenario, we can always open a new api endpoint if we need more information.

@hanzei hanzei added this to the v0.3.0 milestone Apr 13, 2021
@hanzei hanzei added the Docs/Not Needed Does not require documentation label Apr 13, 2021
@larkox larkox requested a review from levb April 16, 2021 07:26
@hanzei hanzei modified the milestones: v0.3.0, v0.4.0 Apr 17, 2021
@levb levb added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Apr 20, 2021
@levb levb merged commit 21a6589 into mattermost:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Docs/Not Needed Does not require documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants